You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by cs...@apache.org on 2012/05/30 11:18:34 UTC
svn commit: r1344165 - /karaf/trunk/demos/pom.xml
Author: cschneider
Date: Wed May 30 09:18:34 2012
New Revision: 1344165
URL: http://svn.apache.org/viewvc?rev=1344165&view=rev
Log:
KARAF-1509 Disabling the deployer demo for the moment as the build fails there
Modified:
karaf/trunk/demos/pom.xml
Modified: karaf/trunk/demos/pom.xml
URL: http://svn.apache.org/viewvc/karaf/trunk/demos/pom.xml?rev=1344165&r1=1344164&r2=1344165&view=diff
==============================================================================
--- karaf/trunk/demos/pom.xml (original)
+++ karaf/trunk/demos/pom.xml Wed May 30 09:18:34 2012
@@ -38,7 +38,9 @@
<module>branding</module>
<module>command</module>
<module>dump</module>
+ <!-- Disabling this for the moment as the build fails at the my-kar.pom
<module>deployer</module>
+ -->
</modules>
</project>
Re: svn commit: r1344165 - /karaf/trunk/demos/pom.xml
Posted by "Jamie G." <ja...@gmail.com>.
The directory structure resources/resources come from how we package
all karaf 3 demos as Kars.
We have two general folders: filtered and 'regular' resources from the
point of view of the car packaging.
The filtered resources we process to substitute versions, etc at build
time. The resources are just collected and placed into the demos kars.
-J
On Wed, May 30, 2012 at 8:13 AM, Achim Nierbeck <bc...@googlemail.com> wrote:
> TBH, I still think changing the failing "Test" is cheating
> therefore I rather have a not successful test then "shooting the messenger"
>
> Achim
>
> 2012/5/30 Christian Schneider <ch...@die-schneider.net>:
>> To me the deployer demo looks strange. If you look at the pom:
>> <modules>
>> <module>src/main/resources/resources/demos/deployer/kar</module>
>> <module>src/main/resources/resources/demos/deployer/bundle</module>
>> </modules>
>>
>> I have never seen before that modules reside inside a src/main/resources
>> dir. So this may be the cause of the build failure.
>>
>> So I would like to consult Jamie who wrote this before reverting and
>> breaking the build again. I hope you agree that this is better than simply
>> reverting and sacrificing a working build.
>>
>> Christian
>>
>> Am 30.05.2012 11:44, schrieb Achim Nierbeck:
>>
>>> No, strongly disagree.
>>> Since we don't have a full set of itests I consider our demos to be
>>> part of those.
>>> So it's more crucial to fix the cause of the failing demo then
>>> disabling the demo!
>>>
>>> Achim
>>>
>>> 2012/5/30 Christian Schneider<ch...@die-schneider.net>:
>>>>
>>>> I think to fix the build is the higher priority. So if this makes the
>>>> build
>>>> work again I happilly live without a single demo for some time till
>>>> we fix the cause.
>>>>
>>>> Christian
>>>>
>>>> Am 30.05.2012 11:20, schrieb Achim Nierbeck:
>>>>
>>>>> -1 please fix the cause not shoot the messenger
>>>>>
>>>>> 2012/5/30<cs...@apache.org>:
>>>>>>
>>>>>> Author: cschneider
>>>>>> Date: Wed May 30 09:18:34 2012
>>>>>> New Revision: 1344165
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=1344165&view=rev
>>>>>> Log:
>>>>>> KARAF-1509 Disabling the deployer demo for the moment as the build
>>>>>> fails
>>>>>> there
>>>>>>
>>>>>> Modified:
>>>>>> karaf/trunk/demos/pom.xml
>>>>>>
>>>>>> Modified: karaf/trunk/demos/pom.xml
>>>>>> URL:
>>>>>>
>>>>>> http://svn.apache.org/viewvc/karaf/trunk/demos/pom.xml?rev=1344165&r1=1344164&r2=1344165&view=diff
>>>>>>
>>>>>>
>>>>>> ==============================================================================
>>>>>> --- karaf/trunk/demos/pom.xml (original)
>>>>>> +++ karaf/trunk/demos/pom.xml Wed May 30 09:18:34 2012
>>>>>> @@ -38,7 +38,9 @@
>>>>>> <module>branding</module>
>>>>>> <module>command</module>
>>>>>> <module>dump</module>
>>>>>> +<!-- Disabling this for the moment as the build fails at the
>>>>>> my-kar.pom
>>>>>> <module>deployer</module>
>>>>>> + -->
>>>>>> </modules>
>>>>>>
>>>>>> </project>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>> --
>>>> Christian Schneider
>>>> http://www.liquid-reality.de
>>>>
>>>> Open Source Architect
>>>> Talend Application Integration Division http://www.talend.com
>>>>
>>>
>>>
>>
>>
>> --
>> Christian Schneider
>> http://www.liquid-reality.de
>>
>> Open Source Architect
>> Talend Application Integration Division http://www.talend.com
>>
>
>
>
> --
>
> Apache Karaf <http://karaf.apache.org/> Committer & PMC
> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
> Committer & Project Lead
> OPS4J Pax for Vaadin
> <http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter & Project
> Lead
> blog <http://notizblog.nierbeck.de/>
Re: svn commit: r1344165 - /karaf/trunk/demos/pom.xml
Posted by Christian Schneider <ch...@die-schneider.net>.
If it was just a failing test I would fully support this. The problem is
that in this case the full build fails.
In cases like this I always opt for turning the part off that makes the
build fail as it is important to get the other results.
Still turning off parts of the build should be as short lived as possible.
In any case Jamie is currently working on it and I am quite sure he can
fix it shortly.
Christian
Am 30.05.2012 12:43, schrieb Achim Nierbeck:
> TBH, I still think changing the failing "Test" is cheating
> therefore I rather have a not successful test then "shooting the messenger"
>
> Achim
>
> 2012/5/30 Christian Schneider<ch...@die-schneider.net>:
>> To me the deployer demo looks strange. If you look at the pom:
>> <modules>
>> <module>src/main/resources/resources/demos/deployer/kar</module>
>> <module>src/main/resources/resources/demos/deployer/bundle</module>
>> </modules>
>>
>> I have never seen before that modules reside inside a src/main/resources
>> dir. So this may be the cause of the build failure.
>>
>> So I would like to consult Jamie who wrote this before reverting and
>> breaking the build again. I hope you agree that this is better than simply
>> reverting and sacrificing a working build.
>>
>> Christian
>>
>> Am 30.05.2012 11:44, schrieb Achim Nierbeck:
>>
>>> No, strongly disagree.
>>> Since we don't have a full set of itests I consider our demos to be
>>> part of those.
>>> So it's more crucial to fix the cause of the failing demo then
>>> disabling the demo!
>>>
>>> Achim
>>>
>>> 2012/5/30 Christian Schneider<ch...@die-schneider.net>:
>>>> I think to fix the build is the higher priority. So if this makes the
>>>> build
>>>> work again I happilly live without a single demo for some time till
>>>> we fix the cause.
>>>>
>>>> Christian
>>>>
>>>> Am 30.05.2012 11:20, schrieb Achim Nierbeck:
>>>>
>>>>> -1 please fix the cause not shoot the messenger
>>>>>
>>>>> 2012/5/30<cs...@apache.org>:
>>>>>> Author: cschneider
>>>>>> Date: Wed May 30 09:18:34 2012
>>>>>> New Revision: 1344165
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=1344165&view=rev
>>>>>> Log:
>>>>>> KARAF-1509 Disabling the deployer demo for the moment as the build
>>>>>> fails
>>>>>> there
>>>>>>
>>>>>> Modified:
>>>>>> karaf/trunk/demos/pom.xml
>>>>>>
>>>>>> Modified: karaf/trunk/demos/pom.xml
>>>>>> URL:
>>>>>>
>>>>>> http://svn.apache.org/viewvc/karaf/trunk/demos/pom.xml?rev=1344165&r1=1344164&r2=1344165&view=diff
>>>>>>
>>>>>>
>>>>>> ==============================================================================
>>>>>> --- karaf/trunk/demos/pom.xml (original)
>>>>>> +++ karaf/trunk/demos/pom.xml Wed May 30 09:18:34 2012
>>>>>> @@ -38,7 +38,9 @@
>>>>>> <module>branding</module>
>>>>>> <module>command</module>
>>>>>> <module>dump</module>
>>>>>> +<!-- Disabling this for the moment as the build fails at the
>>>>>> my-kar.pom
>>>>>> <module>deployer</module>
>>>>>> + -->
>>>>>> </modules>
>>>>>>
>>>>>> </project>
>>>>>>
>>>>>>
>>>> --
>>>> Christian Schneider
>>>> http://www.liquid-reality.de
>>>>
>>>> Open Source Architect
>>>> Talend Application Integration Division http://www.talend.com
>>>>
>>>
>>
>> --
>> Christian Schneider
>> http://www.liquid-reality.de
>>
>> Open Source Architect
>> Talend Application Integration Division http://www.talend.com
>>
>
>
--
Christian Schneider
http://www.liquid-reality.de
Open Source Architect
Talend Application Integration Division http://www.talend.com
Re: svn commit: r1344165 - /karaf/trunk/demos/pom.xml
Posted by Achim Nierbeck <bc...@googlemail.com>.
TBH, I still think changing the failing "Test" is cheating
therefore I rather have a not successful test then "shooting the messenger"
Achim
2012/5/30 Christian Schneider <ch...@die-schneider.net>:
> To me the deployer demo looks strange. If you look at the pom:
> <modules>
> <module>src/main/resources/resources/demos/deployer/kar</module>
> <module>src/main/resources/resources/demos/deployer/bundle</module>
> </modules>
>
> I have never seen before that modules reside inside a src/main/resources
> dir. So this may be the cause of the build failure.
>
> So I would like to consult Jamie who wrote this before reverting and
> breaking the build again. I hope you agree that this is better than simply
> reverting and sacrificing a working build.
>
> Christian
>
> Am 30.05.2012 11:44, schrieb Achim Nierbeck:
>
>> No, strongly disagree.
>> Since we don't have a full set of itests I consider our demos to be
>> part of those.
>> So it's more crucial to fix the cause of the failing demo then
>> disabling the demo!
>>
>> Achim
>>
>> 2012/5/30 Christian Schneider<ch...@die-schneider.net>:
>>>
>>> I think to fix the build is the higher priority. So if this makes the
>>> build
>>> work again I happilly live without a single demo for some time till
>>> we fix the cause.
>>>
>>> Christian
>>>
>>> Am 30.05.2012 11:20, schrieb Achim Nierbeck:
>>>
>>>> -1 please fix the cause not shoot the messenger
>>>>
>>>> 2012/5/30<cs...@apache.org>:
>>>>>
>>>>> Author: cschneider
>>>>> Date: Wed May 30 09:18:34 2012
>>>>> New Revision: 1344165
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1344165&view=rev
>>>>> Log:
>>>>> KARAF-1509 Disabling the deployer demo for the moment as the build
>>>>> fails
>>>>> there
>>>>>
>>>>> Modified:
>>>>> karaf/trunk/demos/pom.xml
>>>>>
>>>>> Modified: karaf/trunk/demos/pom.xml
>>>>> URL:
>>>>>
>>>>> http://svn.apache.org/viewvc/karaf/trunk/demos/pom.xml?rev=1344165&r1=1344164&r2=1344165&view=diff
>>>>>
>>>>>
>>>>> ==============================================================================
>>>>> --- karaf/trunk/demos/pom.xml (original)
>>>>> +++ karaf/trunk/demos/pom.xml Wed May 30 09:18:34 2012
>>>>> @@ -38,7 +38,9 @@
>>>>> <module>branding</module>
>>>>> <module>command</module>
>>>>> <module>dump</module>
>>>>> +<!-- Disabling this for the moment as the build fails at the
>>>>> my-kar.pom
>>>>> <module>deployer</module>
>>>>> + -->
>>>>> </modules>
>>>>>
>>>>> </project>
>>>>>
>>>>>
>>>>
>>>
>>> --
>>> Christian Schneider
>>> http://www.liquid-reality.de
>>>
>>> Open Source Architect
>>> Talend Application Integration Division http://www.talend.com
>>>
>>
>>
>
>
> --
> Christian Schneider
> http://www.liquid-reality.de
>
> Open Source Architect
> Talend Application Integration Division http://www.talend.com
>
--
Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
Committer & Project Lead
OPS4J Pax for Vaadin
<http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter & Project
Lead
blog <http://notizblog.nierbeck.de/>
Re: svn commit: r1344165 - /karaf/trunk/demos/pom.xml
Posted by Christian Schneider <ch...@die-schneider.net>.
To me the deployer demo looks strange. If you look at the pom:
<modules>
<module>src/main/resources/resources/demos/deployer/kar</module>
<module>src/main/resources/resources/demos/deployer/bundle</module>
</modules>
I have never seen before that modules reside inside a src/main/resources
dir. So this may be the cause of the build failure.
So I would like to consult Jamie who wrote this before reverting and
breaking the build again. I hope you agree that this is better than
simply reverting and sacrificing a working build.
Christian
Am 30.05.2012 11:44, schrieb Achim Nierbeck:
> No, strongly disagree.
> Since we don't have a full set of itests I consider our demos to be
> part of those.
> So it's more crucial to fix the cause of the failing demo then
> disabling the demo!
>
> Achim
>
> 2012/5/30 Christian Schneider<ch...@die-schneider.net>:
>> I think to fix the build is the higher priority. So if this makes the build
>> work again I happilly live without a single demo for some time till
>> we fix the cause.
>>
>> Christian
>>
>> Am 30.05.2012 11:20, schrieb Achim Nierbeck:
>>
>>> -1 please fix the cause not shoot the messenger
>>>
>>> 2012/5/30<cs...@apache.org>:
>>>> Author: cschneider
>>>> Date: Wed May 30 09:18:34 2012
>>>> New Revision: 1344165
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1344165&view=rev
>>>> Log:
>>>> KARAF-1509 Disabling the deployer demo for the moment as the build fails
>>>> there
>>>>
>>>> Modified:
>>>> karaf/trunk/demos/pom.xml
>>>>
>>>> Modified: karaf/trunk/demos/pom.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/karaf/trunk/demos/pom.xml?rev=1344165&r1=1344164&r2=1344165&view=diff
>>>>
>>>> ==============================================================================
>>>> --- karaf/trunk/demos/pom.xml (original)
>>>> +++ karaf/trunk/demos/pom.xml Wed May 30 09:18:34 2012
>>>> @@ -38,7 +38,9 @@
>>>> <module>branding</module>
>>>> <module>command</module>
>>>> <module>dump</module>
>>>> +<!-- Disabling this for the moment as the build fails at the my-kar.pom
>>>> <module>deployer</module>
>>>> + -->
>>>> </modules>
>>>>
>>>> </project>
>>>>
>>>>
>>>
>>
>> --
>> Christian Schneider
>> http://www.liquid-reality.de
>>
>> Open Source Architect
>> Talend Application Integration Division http://www.talend.com
>>
>
>
--
Christian Schneider
http://www.liquid-reality.de
Open Source Architect
Talend Application Integration Division http://www.talend.com
Re: svn commit: r1344165 - /karaf/trunk/demos/pom.xml
Posted by Achim Nierbeck <bc...@googlemail.com>.
No, strongly disagree.
Since we don't have a full set of itests I consider our demos to be
part of those.
So it's more crucial to fix the cause of the failing demo then
disabling the demo!
Achim
2012/5/30 Christian Schneider <ch...@die-schneider.net>:
> I think to fix the build is the higher priority. So if this makes the build
> work again I happilly live without a single demo for some time till
> we fix the cause.
>
> Christian
>
> Am 30.05.2012 11:20, schrieb Achim Nierbeck:
>
>> -1 please fix the cause not shoot the messenger
>>
>> 2012/5/30<cs...@apache.org>:
>>>
>>> Author: cschneider
>>> Date: Wed May 30 09:18:34 2012
>>> New Revision: 1344165
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1344165&view=rev
>>> Log:
>>> KARAF-1509 Disabling the deployer demo for the moment as the build fails
>>> there
>>>
>>> Modified:
>>> karaf/trunk/demos/pom.xml
>>>
>>> Modified: karaf/trunk/demos/pom.xml
>>> URL:
>>> http://svn.apache.org/viewvc/karaf/trunk/demos/pom.xml?rev=1344165&r1=1344164&r2=1344165&view=diff
>>>
>>> ==============================================================================
>>> --- karaf/trunk/demos/pom.xml (original)
>>> +++ karaf/trunk/demos/pom.xml Wed May 30 09:18:34 2012
>>> @@ -38,7 +38,9 @@
>>> <module>branding</module>
>>> <module>command</module>
>>> <module>dump</module>
>>> +<!-- Disabling this for the moment as the build fails at the my-kar.pom
>>> <module>deployer</module>
>>> + -->
>>> </modules>
>>>
>>> </project>
>>>
>>>
>>
>>
>
>
> --
> Christian Schneider
> http://www.liquid-reality.de
>
> Open Source Architect
> Talend Application Integration Division http://www.talend.com
>
--
Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
Committer & Project Lead
OPS4J Pax for Vaadin
<http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter & Project
Lead
blog <http://notizblog.nierbeck.de/>
Re: svn commit: r1344165 - /karaf/trunk/demos/pom.xml
Posted by Christian Schneider <ch...@die-schneider.net>.
I think to fix the build is the higher priority. So if this makes the
build work again I happilly live without a single demo for some time till
we fix the cause.
Christian
Am 30.05.2012 11:20, schrieb Achim Nierbeck:
> -1 please fix the cause not shoot the messenger
>
> 2012/5/30<cs...@apache.org>:
>> Author: cschneider
>> Date: Wed May 30 09:18:34 2012
>> New Revision: 1344165
>>
>> URL: http://svn.apache.org/viewvc?rev=1344165&view=rev
>> Log:
>> KARAF-1509 Disabling the deployer demo for the moment as the build fails there
>>
>> Modified:
>> karaf/trunk/demos/pom.xml
>>
>> Modified: karaf/trunk/demos/pom.xml
>> URL: http://svn.apache.org/viewvc/karaf/trunk/demos/pom.xml?rev=1344165&r1=1344164&r2=1344165&view=diff
>> ==============================================================================
>> --- karaf/trunk/demos/pom.xml (original)
>> +++ karaf/trunk/demos/pom.xml Wed May 30 09:18:34 2012
>> @@ -38,7 +38,9 @@
>> <module>branding</module>
>> <module>command</module>
>> <module>dump</module>
>> +<!-- Disabling this for the moment as the build fails at the my-kar.pom
>> <module>deployer</module>
>> + -->
>> </modules>
>>
>> </project>
>>
>>
>
>
--
Christian Schneider
http://www.liquid-reality.de
Open Source Architect
Talend Application Integration Division http://www.talend.com
Re: svn commit: r1344165 - /karaf/trunk/demos/pom.xml
Posted by Achim Nierbeck <bc...@googlemail.com>.
-1 please fix the cause not shoot the messenger
2012/5/30 <cs...@apache.org>:
> Author: cschneider
> Date: Wed May 30 09:18:34 2012
> New Revision: 1344165
>
> URL: http://svn.apache.org/viewvc?rev=1344165&view=rev
> Log:
> KARAF-1509 Disabling the deployer demo for the moment as the build fails there
>
> Modified:
> karaf/trunk/demos/pom.xml
>
> Modified: karaf/trunk/demos/pom.xml
> URL: http://svn.apache.org/viewvc/karaf/trunk/demos/pom.xml?rev=1344165&r1=1344164&r2=1344165&view=diff
> ==============================================================================
> --- karaf/trunk/demos/pom.xml (original)
> +++ karaf/trunk/demos/pom.xml Wed May 30 09:18:34 2012
> @@ -38,7 +38,9 @@
> <module>branding</module>
> <module>command</module>
> <module>dump</module>
> + <!-- Disabling this for the moment as the build fails at the my-kar.pom
> <module>deployer</module>
> + -->
> </modules>
>
> </project>
>
>
--
Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
Committer & Project Lead
OPS4J Pax for Vaadin
<http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter & Project
Lead
blog <http://notizblog.nierbeck.de/>