You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "smiklosovic (via GitHub)" <gi...@apache.org> on 2023/04/10 20:54:26 UTC
[GitHub] [cassandra] smiklosovic opened a new pull request, #2268: CASSANDRA-18124 4.1
smiklosovic opened a new pull request, #2268:
URL: https://github.com/apache/cassandra/pull/2268
Thanks for sending a pull request! Here are some tips if you're new here:
* Ensure you have added or run the [appropriate tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
* Be sure to keep the PR description updated to reflect all changes.
* Write your PR title to summarize what this PR proposes.
* If possible, provide a concise example to reproduce the issue for a faster review.
* Read our [contributor guidelines](https://cassandra.apache.org/_/development/index.html)
* If you're making a documentation change, see our [guide to documentation contribution](https://cassandra.apache.org/_/development/documentation.html)
Commit messages should follow the following format:
```
<One sentence description, usually Jira title or CHANGES.txt summary>
<Optional lengthier description (context on patch)>
patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>
```
The [Cassandra Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maulin-vasavada commented on a diff in pull request #2268: CASSANDRA-18124 4.1
Posted by "maulin-vasavada (via GitHub)" <gi...@apache.org>.
maulin-vasavada commented on code in PR #2268:
URL: https://github.com/apache/cassandra/pull/2268#discussion_r1162168595
##########
examples/ssl-factory/test/unit/org/apache/cassandra/security/KubernetesSecretsSslContextFactoryTest.java:
##########
@@ -149,18 +149,6 @@ public void buildTrustManagerFactoryHappyPath() throws IOException
Assert.assertNotNull(trustManagerFactory);
}
- @Test(expected = IOException.class)
Review Comment:
I found it! Since the failing test is about testing for Invalid Keystore file path, I added below lines in the test. Without those two lines, the new code generates `IllegalArgumentException` since Password is mandatory for file based keystores even before getting to read the keystore file path.
`
config.put(KEYSTORE_PASSWORD_ENV_VAR, "MY_KEYSTORE_PASSWORD");
config.put("MY_KEYSTORE_PASSWORD","ThisWontMatter");
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maulin-vasavada commented on a diff in pull request #2268: CASSANDRA-18124 4.1
Posted by "maulin-vasavada (via GitHub)" <gi...@apache.org>.
maulin-vasavada commented on code in PR #2268:
URL: https://github.com/apache/cassandra/pull/2268#discussion_r1162149327
##########
examples/ssl-factory/test/unit/org/apache/cassandra/security/KubernetesSecretsSslContextFactoryTest.java:
##########
@@ -149,18 +149,6 @@ public void buildTrustManagerFactoryHappyPath() throws IOException
Assert.assertNotNull(trustManagerFactory);
}
- @Test(expected = IOException.class)
Review Comment:
I remember I fixed that one. Let me find out where did it go :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2268: CASSANDRA-18124 4.1
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2268:
URL: https://github.com/apache/cassandra/pull/2268#discussion_r1162081014
##########
examples/ssl-factory/test/unit/org/apache/cassandra/security/KubernetesSecretsSslContextFactoryTest.java:
##########
@@ -149,18 +149,6 @@ public void buildTrustManagerFactoryHappyPath() throws IOException
Assert.assertNotNull(trustManagerFactory);
}
- @Test(expected = IOException.class)
Review Comment:
This test was just failing because it was throwing different exception.
Would be great if somebody doublechecked this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2268: CASSANDRA-18124 4.1
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2268:
URL: https://github.com/apache/cassandra/pull/2268#discussion_r1162115704
##########
examples/ssl-factory/test/unit/org/apache/cassandra/security/KubernetesSecretsSslContextFactoryTest.java:
##########
@@ -149,18 +149,6 @@ public void buildTrustManagerFactoryHappyPath() throws IOException
Assert.assertNotNull(trustManagerFactory);
}
- @Test(expected = IOException.class)
Review Comment:
even though I set keystore_password in `config` in this test, it still says that it is null but it should not ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #2268: CASSANDRA-18124 4.1
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic closed pull request #2268: CASSANDRA-18124 4.1
URL: https://github.com/apache/cassandra/pull/2268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org