[jira] Commented: (HTTPCLIENT-835) Thread safety and visibility Improvements

["Sebb (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683216#action_12683216 ] 

Sebb commented on HTTPCLIENT-835:
---------------------------------

org.apache.http.impl.client.RoutedRequest has two final protected fields.

However both of these are also accessible via public get() methods, so the fields could be made private.
The class does not currently have any subclasses.

> Thread safety and visibility Improvements
> -----------------------------------------
>
>                 Key: HTTPCLIENT-835
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-835
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>            Reporter: Sebb
>
> AbstractAuthenticationHandler.DEFAULT_SCHEME_PRIORITY is not protected against external changes.
> Although the field is private, subclasses can obtain a reference to it and so may be able to change it.
> Consider making the list read-only, or returning a copy instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org