You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yida Wu (Code Review)" <ge...@cloudera.org> on 2022/03/22 04:02:17 UTC

[Impala-ASF-CR] IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure

Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18342


Change subject: IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure
......................................................................

IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure

The testcase succeeds in DEBUG and RELEASE, but fails in ASAN and
TSAN build.

In the testcase's logic, it monitors whether there is a change
of the process vm size or not after several new and deletion of
objects in the system, because ASAN has replaced the alloc/free
interface, it may not guarantee the memory must be released to
the system immediately in ASAN. Similar case in TSAN.

The fix is to disable the testcase running in ASAN and TSAN.
Similar testcase MetricsTest::MemMetric can be found which also
disables to run in ASAN and TSAN build.

Tests:
Reran testcase in ASAN and TSAN without errors.

Change-Id: Id40a2ae184bba670a3538dedfb8ff25d24dc9b6c
---
M be/src/runtime/client-cache-test.cc
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/18342/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id40a2ae184bba670a3538dedfb8ff25d24dc9b6c
Gerrit-Change-Number: 18342
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>

[Impala-ASF-CR] IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure

Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18342 )

Change subject: IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id40a2ae184bba670a3538dedfb8ff25d24dc9b6c
Gerrit-Change-Number: 18342
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Mar 2022 14:49:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18342 )

Change subject: IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7954/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id40a2ae184bba670a3538dedfb8ff25d24dc9b6c
Gerrit-Change-Number: 18342
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Mar 2022 15:42:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18342 )

Change subject: IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10322/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id40a2ae184bba670a3538dedfb8ff25d24dc9b6c
Gerrit-Change-Number: 18342
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Mar 2022 15:06:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18342 )

Change subject: IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure
......................................................................

IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure

The testcase succeeds in DEBUG and RELEASE, but fails in ASAN and
TSAN build.

In the testcase's logic, it monitors whether there is a change
of the process vm size or not after several new and deletion of
objects in the system, because ASAN has replaced the alloc/free
interface, it may not guarantee the memory must be released to
the system immediately in ASAN. Similar case in TSAN.

The fix disables the testcase running in ASAN and TSAN, and the
running of this testcase in the DEBUG and RELEASE builds should
be enough for the verification of the memory leak problem in
IMPALA-11176.

Tests:
Reran testcase in ASAN and TSAN without errors.

Change-Id: Id40a2ae184bba670a3538dedfb8ff25d24dc9b6c
Reviewed-on: http://gerrit.cloudera.org:8080/18342
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/client-cache-test.cc
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id40a2ae184bba670a3538dedfb8ff25d24dc9b6c
Gerrit-Change-Number: 18342
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18342 )

Change subject: IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7954/


-- 
To view, visit http://gerrit.cloudera.org:8080/18342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id40a2ae184bba670a3538dedfb8ff25d24dc9b6c
Gerrit-Change-Number: 18342
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Mar 2022 20:03:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18342 )

Change subject: IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10320/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id40a2ae184bba670a3538dedfb8ff25d24dc9b6c
Gerrit-Change-Number: 18342
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Mar 2022 04:21:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18342 )

Change subject: IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id40a2ae184bba670a3538dedfb8ff25d24dc9b6c
Gerrit-Change-Number: 18342
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Mar 2022 01:37:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18342 )

Change subject: IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure
......................................................................

IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure

The testcase succeeds in DEBUG and RELEASE, but fails in ASAN and
TSAN build.

In the testcase's logic, it monitors whether there is a change
of the process vm size or not after several new and deletion of
objects in the system, because ASAN has replaced the alloc/free
interface, it may not guarantee the memory must be released to
the system immediately in ASAN. Similar case in TSAN.

The fix disables the testcase running in ASAN and TSAN, and the
running of this testcase in the DEBUG and RELEASE builds should
be enough for the verification of the memory leak problem in
IMPALA-11176.

Tests:
Reran testcase in ASAN and TSAN without errors.

Change-Id: Id40a2ae184bba670a3538dedfb8ff25d24dc9b6c
---
M be/src/runtime/client-cache-test.cc
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/18342/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id40a2ae184bba670a3538dedfb8ff25d24dc9b6c
Gerrit-Change-Number: 18342
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18342 )

Change subject: IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7956/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id40a2ae184bba670a3538dedfb8ff25d24dc9b6c
Gerrit-Change-Number: 18342
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Mar 2022 21:15:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18342 )

Change subject: IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id40a2ae184bba670a3538dedfb8ff25d24dc9b6c
Gerrit-Change-Number: 18342
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Mar 2022 15:42:38 +0000
Gerrit-HasComments: No