You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tajo.apache.org by hyoungjun kim <ba...@gmail.com> on 2014/01/29 08:35:14 UTC

Review Request 17486: TAJO-566: BIN/TAJO_DUMP makes wrong ddl script.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17486/
-----------------------------------------------------------

Review request for Tajo.


Bugs: TAJO-566
    https://issues.apache.org/jira/browse/TAJO-566


Repository: tajo


Description
-------

BIN/TAJO_DUMP makes wrong ddl script.
* duplicated partition column 
* no data type in PARTITION BY COLUMN
* PARTITION BY COLUMN clause must be placed before LOCATION 
The following is dump result.
{code}
CREATE EXTERNAL TABLE test1 (col1 TEXT, col2 TEXT, col3 TEXT) USING CSV WITH (csvfile.delimiter=


Diffs
-----

  tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java 1ae77b4b85776516135d08563ef5417c6f73cf7c 
  tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestDDLBuilder.java 390c348b6aa0dc2e68d5a2d2b79f7291f8077120 
  tajo-core/tajo-core-backend/src/test/resources/results/testBuildDDL.result dd111880fca16013c5b8ee5bd403b0df08d44999 

Diff: https://reviews.apache.org/r/17486/diff/


Testing
-------


Thanks,

hyoungjun kim