You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/13 08:59:41 UTC
[jira] [Commented] (CAMEL-10817) dumpModelAsXml can return invalid
XML namespace xmlns:xmlns
[ https://issues.apache.org/jira/browse/CAMEL-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863351#comment-15863351 ]
ASF GitHub Bot commented on CAMEL-10817:
----------------------------------------
GitHub user jamesnetherton opened a pull request:
https://github.com/apache/camel/pull/1459
CAMEL-10817: Prevent duplicated xmlns namespace prefix
https://issues.apache.org/jira/browse/CAMEL-10817
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jamesnetherton/camel CAMEL-10817
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1459.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1459
----
commit f41bc2ec16b9963b52646dd487b9d07e8c38a556
Author: James Netherton <ja...@gmail.com>
Date: 2017-02-13T08:43:58Z
CAMEL-10817: Prevent duplicated xmlns namespace prefix when dumping model XML
----
> dumpModelAsXml can return invalid XML namespace xmlns:xmlns
> -----------------------------------------------------------
>
> Key: CAMEL-10817
> URL: https://issues.apache.org/jira/browse/CAMEL-10817
> Project: Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.18.0
> Reporter: James Netherton
> Assignee: James Netherton
> Priority: Minor
>
> Seems I introduced a [bug|https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/model/ModelHelper.java#L99] when implementing CAMEL-10509.
> If we're processing a namespace prefix of 'xmlns' then obviously we should not prefix it with the same value. But currently this is allowed and a namespace prefix of 'xmlns:xmlns' is added to the {{<routes>}} element. This can mean that the output from {{ModelHelper.dumpModelAsXml}} is invalid.
> However, I can only reproduce the problem on Karaf where the routes use xpath expressions. Some how with other platforms & scenarios the 'xmlns:xmlns' value is being ignored and never makes it into the {{dumpModelAsXml}} output.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)