You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2015/06/26 09:13:54 UTC
Re: svn commit: r1687679 -
/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
Thanks Nicolas, Zhang,
My bad I did not compile/test on trunk HEAD but on an older revision :/
And of course again https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-9682 :/
Jacques
Le 26/06/2015 09:04, nmalin@apache.org a écrit :
> Author: nmalin
> Date: Fri Jun 26 07:04:55 2015
> New Revision: 1687679
>
> URL: http://svn.apache.org/r1687679
> Log:
> correct compilation error, missing delegatorBaseName parameter for function GenericDelegator.getEntityNamesByGroup. Issue OFBIZ-6533, thanks Wei Zhang for this alert
>
> Modified:
> ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
>
> Modified: ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java?rev=1687679&r1=1687678&r2=1687679&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java (original)
> +++ ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java Fri Jun 26 07:04:55 2015
> @@ -423,7 +423,7 @@ public class GenericDelegator implements
> */
> @Override
> public Map<String, ModelEntity> getModelEntityMapByGroup(String groupName) throws GenericEntityException {
> - Set<String> entityNameSet = getModelGroupReader().getEntityNamesByGroup(groupName);
> + Set<String> entityNameSet = getModelGroupReader().getEntityNamesByGroup(delegatorBaseName, groupName);
>
> if (this.delegatorInfo.getDefaultGroupName().equals(groupName)) {
> // add all entities with no group name to the Set
>
>
>
Re: svn commit: r1687679 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
Posted by Nicolas Malin <ni...@nereide.fr>.
don't worries Jacques ;)
Can you confirm the correction ? I will close the jira issue if it's done.
Nicolas
Le 26/06/2015 09:13, Jacques Le Roux a écrit :
> Thanks Nicolas, Zhang,
>
> My bad I did not compile/test on trunk HEAD but on an older revision :/
> And of course again
> https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-9682 :/
>
>
> Jacques
>
> Le 26/06/2015 09:04, nmalin@apache.org a écrit :
>> Author: nmalin
>> Date: Fri Jun 26 07:04:55 2015
>> New Revision: 1687679
>>
>> URL: http://svn.apache.org/r1687679
>> Log:
>> correct compilation error, missing delegatorBaseName parameter for
>> function GenericDelegator.getEntityNamesByGroup. Issue OFBIZ-6533,
>> thanks Wei Zhang for this alert
>>
>> Modified:
>> ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
>>
>> Modified:
>> ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java?rev=1687679&r1=1687678&r2=1687679&view=diff
>> ==============================================================================
>>
>> ---
>> ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
>> (original)
>> +++
>> ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
>> Fri Jun 26 07:04:55 2015
>> @@ -423,7 +423,7 @@ public class GenericDelegator implements
>> */
>> @Override
>> public Map<String, ModelEntity> getModelEntityMapByGroup(String
>> groupName) throws GenericEntityException {
>> - Set<String> entityNameSet =
>> getModelGroupReader().getEntityNamesByGroup(groupName);
>> + Set<String> entityNameSet =
>> getModelGroupReader().getEntityNamesByGroup(delegatorBaseName,
>> groupName);
>> if
>> (this.delegatorInfo.getDefaultGroupName().equals(groupName)) {
>> // add all entities with no group name to the Set
>>
>>
>>