[jira] [Commented] (TEZ-1688) Add applicationId as a primary filter for all Timeline data for easier export

["Gopal V (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180934#comment-14180934 ] 

Gopal V commented on TEZ-1688:
------------------------------

LGTM - +1.

I noticed that this uses the same naming convention as YARN applications (instead of being tied to a TEZ_* name). 

That makes a lot of sense, when we integrate this with the RM data - but right now, it looks rather odd in the dumps.

{code}
"primaryfilters": {
                "TEZ_DAG_ID": [
                    "dag_1413959022005_0046_1"
                ],
                "TEZ_VERTEX_ID": [
                    "vertex_1413959022005_0046_1_01"
                ],
                "applicationId": [
                    "application_1413959022005_0046"
                ]
            },
{code}

That is not particularly relevant to fix, but I'm commenting for the sake of some documentation about this.

> Add applicationId as a primary filter for all Timeline data for easier export 
> ------------------------------------------------------------------------------
>
>                 Key: TEZ-1688
>                 URL: https://issues.apache.org/jira/browse/TEZ-1688
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Hitesh Shah
>         Attachments: TEZ-1688.1.patch, TEZ-1688.2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)