You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "zwoop (via GitHub)" <gi...@apache.org> on 2024/08/22 21:34:23 UTC
[PR] Changes all of Cripts to be in Cript:: namespace [trafficserver]
zwoop opened a new pull request, #11734:
URL: https://github.com/apache/trafficserver/pull/11734
This turns out to be required, for Cripts to be able to include core include files (like HttpSM.h) directly. I would like to do that later, bypassing InkAPI in Cripts directly.
This also feels more consistent within all of Cripts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes all of Cripts to be in cripts:: namespace [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop merged PR #11734:
URL: https://github.com/apache/trafficserver/pull/11734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes all of Cripts to be in Cript:: namespace [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #11734:
URL: https://github.com/apache/trafficserver/pull/11734#issuecomment-2312834361
I'm sure there's plenty of inconsistencies, the thought was Cript == The language / and singular "script", Cripts == many scripts (plural).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes all of Cripts to be in Cript:: namespace [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #11734:
URL: https://github.com/apache/trafficserver/pull/11734#issuecomment-2307416613
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes all of Cripts to be in cripts:: namespace [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #11734:
URL: https://github.com/apache/trafficserver/pull/11734#issuecomment-2322244786
Cherry-picked to v10.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes all of Cripts to be in Cript:: namespace [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #11734:
URL: https://github.com/apache/trafficserver/pull/11734#issuecomment-2305852741
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes all of Cripts to be in Cript:: namespace [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #11734:
URL: https://github.com/apache/trafficserver/pull/11734#issuecomment-2305840716
This is going to be an incompatible change. What's the plan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes all of Cripts to be in Cript:: namespace [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #11734:
URL: https://github.com/apache/trafficserver/pull/11734#issuecomment-2305854002
> This is going to be an incompatible change. What's the plan?
Yeh, incompatible. But, we also haven't declared Cripts "stable" yet, so I'm hoping no one will object for this to go into 10.1.0.
I think if for some other reason we re-spin 10.0.0, we should get this in there, but I won't -1 the current vote just for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org