You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/05/11 18:01:59 UTC
[GitHub] [lucene] LuXugang opened a new pull request, #881: LUCENE-10502: add entry
LuXugang opened a new pull request, #881:
URL: https://github.com/apache/lucene/pull/881
Add entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #881: LUCENE-10502: add entry
Posted by GitBox <gi...@apache.org>.
mayya-sharipova commented on code in PR #881:
URL: https://github.com/apache/lucene/pull/881#discussion_r870677297
##########
lucene/CHANGES.txt:
##########
@@ -149,6 +149,9 @@ Optimizations
when the search order and the index order are in opposite directions.
(Jianping Weng)
+* LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle
+ ordToDoc in HNSW vectors (Mayya Sharipova, Julie Tibshirani, Lu Xugang)
Review Comment:
You don't need to add our names (mine and Julie, as we were reviewers), and in any way please put your name first as the main contributor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mayya-sharipova merged pull request #881: LUCENE-10502: add entry
Posted by GitBox <gi...@apache.org>.
mayya-sharipova merged PR #881:
URL: https://github.com/apache/lucene/pull/881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mayya-sharipova commented on pull request #881: LUCENE-10502: add entry
Posted by GitBox <gi...@apache.org>.
mayya-sharipova commented on PR #881:
URL: https://github.com/apache/lucene/pull/881#issuecomment-1124910640
@LuXugang Thanks for your work, please feel free to open PR against `branch_9x` cherry-picking this commit and also 6040d1648f6e30107086c1f9a159c1979498fb4e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] LuXugang commented on a diff in pull request #881: LUCENE-10502: add entry
Posted by GitBox <gi...@apache.org>.
LuXugang commented on code in PR #881:
URL: https://github.com/apache/lucene/pull/881#discussion_r870839898
##########
lucene/CHANGES.txt:
##########
@@ -149,6 +149,9 @@ Optimizations
when the search order and the index order are in opposite directions.
(Jianping Weng)
+* LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle
+ ordToDoc in HNSW vectors (Mayya Sharipova, Julie Tibshirani, Lu Xugang)
Review Comment:
@mayya-sharipova Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] LuXugang commented on pull request #881: LUCENE-10502: add entry
Posted by GitBox <gi...@apache.org>.
LuXugang commented on PR #881:
URL: https://github.com/apache/lucene/pull/881#issuecomment-1124945233
> @LuXugang Thanks for your work, please feel free to open PR against `branch_9x` cherry-picking this commit and also [6040d16](https://github.com/apache/lucene/commit/6040d1648f6e30107086c1f9a159c1979498fb4e)
Hi, @mayya-sharipova see Backports https://github.com/apache/lucene/pull/885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] LuXugang commented on a diff in pull request #881: LUCENE-10502: add entry
Posted by GitBox <gi...@apache.org>.
LuXugang commented on code in PR #881:
URL: https://github.com/apache/lucene/pull/881#discussion_r870839712
##########
lucene/CHANGES.txt:
##########
@@ -149,6 +149,9 @@ Optimizations
when the search order and the index order are in opposite directions.
(Jianping Weng)
+* LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle
+ ordToDoc in HNSW vectors (Mayya Sharipova, Julie Tibshirani, Lu Xugang)
Review Comment:
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org