You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/05/23 13:24:51 UTC
[GitHub] [incubator-pekko] mdedetrich opened a new pull request, #330: Update sbt-apache-sonatype
mdedetrich opened a new pull request, #330:
URL: https://github.com/apache/incubator-pekko/pull/330
Updates sbt-apache-sonatype which brings in https://github.com/mdedetrich/sbt-apache-sonatype/pull/15
References: https://github.com/apache/incubator-pekko/issues/328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich merged pull request #330: Update sbt-apache-sonatype
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #330:
URL: https://github.com/apache/incubator-pekko/pull/330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #330: Update sbt-apache-sonatype
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #330:
URL: https://github.com/apache/incubator-pekko/pull/330#issuecomment-1559524033
Hmm, some tests fail but I will re-run PR just to be safe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #330: Update sbt-apache-sonatype
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #330:
URL: https://github.com/apache/incubator-pekko/pull/330#issuecomment-1559471690
Some projects do seem to add license/notice to all jars - even javadoc jars.
I think the path of least resistance is to fix up the javadoc jars too.
Otherwise, we're probably going to have to get into a debate with Incubator PMC and/or Legal.
@Claudenw wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #330: Update sbt-apache-sonatype
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #330:
URL: https://github.com/apache/incubator-pekko/pull/330#issuecomment-1559490788
> Some projects do seem to add license/notice to all jars - even javadoc jars.
I know, but the `META-INF` folder doesn't even seem to be standard (in the general sense) for `-javadoc`, at least when packaging `-javadoc` locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #330: Update sbt-apache-sonatype
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #330:
URL: https://github.com/apache/incubator-pekko/pull/330#issuecomment-1559437884
@mdedetrich we can merge this but when I tested this on my laptop, the `-sources` jars now have the extra files but the `-javadoc` one does not. This is definite progress. If there is no obvious way to fix the `-javadoc` jar issue, we can bring it to Incubator PMC or Legal and see what they say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #330: Update sbt-apache-sonatype
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #330:
URL: https://github.com/apache/incubator-pekko/pull/330#issuecomment-1559463475
> If there is no obvious way to fix the -javadoc jar issue, we can bring it to Incubator PMC or Legal and see what they say.
I deliberately left out `-javadoc` separately because some projects (i.e. Apache Daffodil) do not contain these files in generated documentation where as every single Apache project I could reference had it in `-sources`.
If its an issue its shouldn't be a problem for me to add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org