You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/12/29 06:39:21 UTC
Review Request 55077: LENS-1379 : Fix session expiry for sessions in
which operations were done
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55077/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1379
https://issues.apache.org/jira/browse/LENS-1379
Repository: lens
Description
-------
Fixes the logic checking for isActive() on a session
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 21e2a62
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 34c901c
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java 8c1bb7b
Diff: https://reviews.apache.org/r/55077/diff/
Testing
-------
All server tests pass.
[INFO] --- maven-surefire-plugin:2.15:test (default-test) @ lens-server ---
[INFO] Surefire report directory: /Users/amareshwari.sr/workspace/lens/lens-server/target/surefire-reports
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
Running TestSuite
Tests run: 328, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,243.282 sec - in TestSuite
Results :
Tests run: 328, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Amareshwari Sriramadasu
Re: Review Request 55077: LENS-1379 : Fix session expiry for sessions
in which operations were done
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55077/#review160319
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On Dec. 30, 2016, 9:33 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55077/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2016, 9:33 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1379
> https://issues.apache.org/jira/browse/LENS-1379
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixes the logic checking for isActive() on a session
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 21e2a62
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 34c901c
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java 8c1bb7b
>
> Diff: https://reviews.apache.org/r/55077/diff/
>
>
> Testing
> -------
>
> All server tests pass.
>
> [INFO] --- maven-surefire-plugin:2.15:test (default-test) @ lens-server ---
> [INFO] Surefire report directory: /Users/amareshwari.sr/workspace/lens/lens-server/target/surefire-reports
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
> Running TestSuite
> Tests run: 328, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,243.282 sec - in TestSuite
>
> Results :
>
> Tests run: 328, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 55077: LENS-1379 : Fix session expiry for sessions
in which operations were done
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55077/
-----------------------------------------------------------
(Updated Dec. 30, 2016, 9:33 a.m.)
Review request for lens.
Changes
-------
Updated restore session to put params directly in conf instead of doing acquire and release of session
Bugs: LENS-1379
https://issues.apache.org/jira/browse/LENS-1379
Repository: lens
Description
-------
Fixes the logic checking for isActive() on a session
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 21e2a62
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 34c901c
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java 8c1bb7b
Diff: https://reviews.apache.org/r/55077/diff/
Testing
-------
All server tests pass.
[INFO] --- maven-surefire-plugin:2.15:test (default-test) @ lens-server ---
[INFO] Surefire report directory: /Users/amareshwari.sr/workspace/lens/lens-server/target/surefire-reports
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
Running TestSuite
Tests run: 328, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,243.282 sec - in TestSuite
Results :
Tests run: 328, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Amareshwari Sriramadasu
Re: Review Request 55077: LENS-1379 : Fix session expiry for sessions
in which operations were done
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55077/#review160270
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On Dec. 29, 2016, 6:39 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55077/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2016, 6:39 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1379
> https://issues.apache.org/jira/browse/LENS-1379
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixes the logic checking for isActive() on a session
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 21e2a62
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 34c901c
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java 8c1bb7b
>
> Diff: https://reviews.apache.org/r/55077/diff/
>
>
> Testing
> -------
>
> All server tests pass.
>
> [INFO] --- maven-surefire-plugin:2.15:test (default-test) @ lens-server ---
> [INFO] Surefire report directory: /Users/amareshwari.sr/workspace/lens/lens-server/target/surefire-reports
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
> Running TestSuite
> Tests run: 328, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,243.282 sec - in TestSuite
>
> Results :
>
> Tests run: 328, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>