You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/21 14:11:15 UTC

[GitHub] [airflow] SamWheating commented on a change in pull request #17121: [WIP] Deactivating DAGs which have been removed from files

SamWheating commented on a change in pull request #17121:
URL: https://github.com/apache/airflow/pull/17121#discussion_r674009622



##########
File path: airflow/dag_processing/processor.py
##########
@@ -618,6 +619,8 @@ def process_file(
             Stats.incr('dag_file_refresh_error', 1, 1)
             return 0, 0
 
+        self._deactivate_missing_dags(session, dagbag, file_path)

Review comment:
       I think that we _do_ want to call the DB if there's no DAGs in a file - if a file used to have one DAG and now has zero then we'll need to mark that DAG is inactive, correct?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org