You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/09/17 02:50:06 UTC
[GitHub] zeppelin pull request #1432: [HOT FIX][ZEPPELIN-1144] Fix compilation errors...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1432
[HOT FIX][ZEPPELIN-1144] Fix compilation errors in Notebook.java
### What is this PR for?
After #1330 merged, the latest master build failed with below compilation errors.
```
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/ahyoungryu/Dev/zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java:[553,31] cannot find symbol
symbol: method id()
location: variable note1 of type org.apache.zeppelin.notebook.Note
[ERROR] /Users/ahyoungryu/Dev/zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java:[557,31] cannot find symbol
symbol: method id()
location: variable note2 of type org.apache.zeppelin.notebook.Note
```
### What type of PR is it?
Hot Fix
### What is the Jira issue?
### How should this be tested?
- Build the latest master branch with `mvn clean package -DskipTests` -> compilation error in `zeppelin-zengine`
- Apply this patch and build with `mvn clean package -DskipTests` -> build success
You can also check #1330 works properly.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin hotfix/ZEPPELIN-1144
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1432.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1432
----
commit 6a3dbd3a33a4a0ffe2614946b243dad63c78e241
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-09-17T02:42:36Z
Fix build error in Notebook.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1432: [HOT FIX][ZEPPELIN-1144] Fix compilation errors in Not...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1432
Tested on local, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1432: [HOT FIX][ZEPPELIN-1144] Fix compilation errors in Not...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1432
looks good, thanks for quick fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1432: [HOT FIX][ZEPPELIN-1144] Fix compilation errors in Not...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1432
Only Selenium test failed now. I'm merging this as a hotfix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1432: [HOT FIX][ZEPPELIN-1144] Fix compilation errors in Not...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1432
Please ignore my previous comments, just realize this is for fix the compilation issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1432: [HOT FIX][ZEPPELIN-1144] Fix compilation errors in Not...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1432
@prabhjyotsingh @AhyoungRyu This make the compilation fails, which affect other PRs. Could you help do a quick fix on it ?
https://travis-ci.org/apache/zeppelin/jobs/160614161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1432: [HOT FIX][ZEPPELIN-1144] Fix compilation errors in Not...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1432
@khalidhuseynov @Leemoonsoo Thanks for the quick verification. Then will merge this one as a hotfix after CI checking!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1432: [HOT FIX][ZEPPELIN-1144] Fix compilation errors in Not...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1432
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1432: [HOT FIX][ZEPPELIN-1144] Fix compilation errors...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1432
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---