You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/24 23:28:04 UTC

[GitHub] [hudi] nsivabalan commented on a diff in pull request #7020: [HUDI-5069] TestInlineCompaction.testSuccessfulCompactionBasedOnNumAndTime is flaky

nsivabalan commented on code in PR #7020:
URL: https://github.com/apache/hudi/pull/7020#discussion_r1003859249


##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/compact/TestInlineCompaction.java:
##########
@@ -229,6 +229,9 @@ public void testSuccessfulCompactionBasedOnNumAndTime() throws Exception {
 
       // Then: ensure no compaction is executed since there are only 3 delta commits
       assertEquals(3, metaClient.getActiveTimeline().getWriteTimeline().countInstants());
+
+      // Ensure the elapsed time > INLINE_COMPACT_TIME_DELTA_SECONDS
+      Thread.sleep(60 * 1000);

Review Comment:
   may I know why its flaky and why would this fix mitigate it. From what I see, we are setting trigger strategy to NUM_AND_TIME. 
   why switching from 20 to 60 secs would work consistently ? 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org