You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Robert Burrell Donkin <ro...@gmail.com> on 2009/09/15 23:30:10 UTC

[smtp/pop3/imap/nntp] Revise ProtocolHandler API

ProtocolHandlerHelper is set through a setter on ProtocolHandler.

IMHO it would be clearer and simpler if the ProtocolHandlerHelper were
renamed ProtocolContext and passed into each appropriate method. so,
the new API would be similar to:

handle(ProtocolContext context)
reset(ProtocolContext context)

opinions?
objections?

- robert

[1] http://svn.apache.org/repos/asf/james/server/trunk/avalon-socket-library/src/main/java/org/apache/james/socket/ProtocolHandler.java
[2] http://svn.apache.org/repos/asf/james/server/trunk/avalon-socket-library/src/main/java/org/apache/james/socket/ProtocolHandlerHelper.java

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

Re: [smtp/pop3/imap/nntp] Revise ProtocolHandler API

Posted by Norman Maurer <no...@apache.org>.
Makes sense..

+1
Norman

2009/9/15 Robert Burrell Donkin <ro...@gmail.com>:
> ProtocolHandlerHelper is set through a setter on ProtocolHandler.
>
> IMHO it would be clearer and simpler if the ProtocolHandlerHelper were
> renamed ProtocolContext and passed into each appropriate method. so,
> the new API would be similar to:
>
> handle(ProtocolContext context)
> reset(ProtocolContext context)
>
> opinions?
> objections?
>
> - robert
>
> [1] http://svn.apache.org/repos/asf/james/server/trunk/avalon-socket-library/src/main/java/org/apache/james/socket/ProtocolHandler.java
> [2] http://svn.apache.org/repos/asf/james/server/trunk/avalon-socket-library/src/main/java/org/apache/james/socket/ProtocolHandlerHelper.java
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org