You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by venkata swamy babu budumuru <ve...@citrix.com> on 2013/02/27 14:53:47 UTC
Review Request: CLOUDSTACK-1429: single account is unable to use same vnet
across multiple physical networks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9651/
-----------------------------------------------------------
Review request for cloudstack and Marcus Sorensen.
Description
-------
to repro
(1) Have an advanced zone with physical networks say Phynet1: 900-905 Phynet2: 905-909
(2) create a Network in physical network1 (id : 200) and deploy a vm (for ex:- network created is using vlan 905 )
(3) create another network in physical network2 (id : 201) and deploy a vm
Observations :
(i) It tried to pick up vlan 905 from physical network 2 (id : 201) and it failed with the following error.
Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Duplicate entry '905-1-3' for key 'i_op_dc_vnet_alloc__vnet__data_center_id__account_id'
Attached patch fixes the issue.
This addresses bug CLOUDSTACK-1429.
Diffs
-----
setup/db/db/schema-40to410.sql 59b2a7d
Diff: https://reviews.apache.org/r/9651/diff/
Testing
-------
Retried the scenario with the dropped index and it works successfully.
Thanks,
venkata swamy babu budumuru
Re: Review Request: CLOUDSTACK-1429: single account is unable to use same
vnet across multiple physical networks
Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9651/#review17377
-----------------------------------------------------------
Looks good as a covering index. Kishan?
- Prasanna Santhanam
On Feb. 27, 2013, 1:53 p.m., venkata swamy babu budumuru wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9651/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2013, 1:53 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Description
> -------
>
> to repro
>
> (1) Have an advanced zone with physical networks say Phynet1: 900-905 Phynet2: 905-909
> (2) create a Network in physical network1 (id : 200) and deploy a vm (for ex:- network created is using vlan 905 )
> (3) create another network in physical network2 (id : 201) and deploy a vm
>
> Observations :
>
> (i) It tried to pick up vlan 905 from physical network 2 (id : 201) and it failed with the following error.
>
> Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Duplicate entry '905-1-3' for key 'i_op_dc_vnet_alloc__vnet__data_center_id__account_id'
>
> Attached patch fixes the issue.
>
>
> This addresses bug CLOUDSTACK-1429.
>
>
> Diffs
> -----
>
> setup/db/db/schema-40to410.sql 59b2a7d
>
> Diff: https://reviews.apache.org/r/9651/diff/
>
>
> Testing
> -------
>
> Retried the scenario with the dropped index and it works successfully.
>
>
> Thanks,
>
> venkata swamy babu budumuru
>
>
Re: Review Request: CLOUDSTACK-1429: single account is unable to use same
vnet across multiple physical networks
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9651/#review17386
-----------------------------------------------------------
Ship it!
Ship It!
- Kishan Kavala
On Feb. 27, 2013, 1:53 p.m., venkata swamy babu budumuru wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9651/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2013, 1:53 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Description
> -------
>
> to repro
>
> (1) Have an advanced zone with physical networks say Phynet1: 900-905 Phynet2: 905-909
> (2) create a Network in physical network1 (id : 200) and deploy a vm (for ex:- network created is using vlan 905 )
> (3) create another network in physical network2 (id : 201) and deploy a vm
>
> Observations :
>
> (i) It tried to pick up vlan 905 from physical network 2 (id : 201) and it failed with the following error.
>
> Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Duplicate entry '905-1-3' for key 'i_op_dc_vnet_alloc__vnet__data_center_id__account_id'
>
> Attached patch fixes the issue.
>
>
> This addresses bug CLOUDSTACK-1429.
>
>
> Diffs
> -----
>
> setup/db/db/schema-40to410.sql 59b2a7d
>
> Diff: https://reviews.apache.org/r/9651/diff/
>
>
> Testing
> -------
>
> Retried the scenario with the dropped index and it works successfully.
>
>
> Thanks,
>
> venkata swamy babu budumuru
>
>
Re: Review Request: CLOUDSTACK-1429: single account is unable to use same
vnet across multiple physical networks
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9651/#review17388
-----------------------------------------------------------
Please send a patch request on the dev-list if this has to go into 4.1 also
- Kishan Kavala
On Feb. 27, 2013, 1:53 p.m., venkata swamy babu budumuru wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9651/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2013, 1:53 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Description
> -------
>
> to repro
>
> (1) Have an advanced zone with physical networks say Phynet1: 900-905 Phynet2: 905-909
> (2) create a Network in physical network1 (id : 200) and deploy a vm (for ex:- network created is using vlan 905 )
> (3) create another network in physical network2 (id : 201) and deploy a vm
>
> Observations :
>
> (i) It tried to pick up vlan 905 from physical network 2 (id : 201) and it failed with the following error.
>
> Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Duplicate entry '905-1-3' for key 'i_op_dc_vnet_alloc__vnet__data_center_id__account_id'
>
> Attached patch fixes the issue.
>
>
> This addresses bug CLOUDSTACK-1429.
>
>
> Diffs
> -----
>
> setup/db/db/schema-40to410.sql 59b2a7d
>
> Diff: https://reviews.apache.org/r/9651/diff/
>
>
> Testing
> -------
>
> Retried the scenario with the dropped index and it works successfully.
>
>
> Thanks,
>
> venkata swamy babu budumuru
>
>
Re: Review Request: CLOUDSTACK-1429: single account is unable to use same
vnet across multiple physical networks
Posted by Marcus Sorensen <sh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9651/#review17251
-----------------------------------------------------------
this looks sensible to me, but I'd want Kishan Kavala to look it over as well since he made the schema constraint change to allow same vlan on different physical networks.
- Marcus Sorensen
On Feb. 27, 2013, 1:53 p.m., venkata swamy babu budumuru wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9651/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2013, 1:53 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Description
> -------
>
> to repro
>
> (1) Have an advanced zone with physical networks say Phynet1: 900-905 Phynet2: 905-909
> (2) create a Network in physical network1 (id : 200) and deploy a vm (for ex:- network created is using vlan 905 )
> (3) create another network in physical network2 (id : 201) and deploy a vm
>
> Observations :
>
> (i) It tried to pick up vlan 905 from physical network 2 (id : 201) and it failed with the following error.
>
> Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Duplicate entry '905-1-3' for key 'i_op_dc_vnet_alloc__vnet__data_center_id__account_id'
>
> Attached patch fixes the issue.
>
>
> This addresses bug CLOUDSTACK-1429.
>
>
> Diffs
> -----
>
> setup/db/db/schema-40to410.sql 59b2a7d
>
> Diff: https://reviews.apache.org/r/9651/diff/
>
>
> Testing
> -------
>
> Retried the scenario with the dropped index and it works successfully.
>
>
> Thanks,
>
> venkata swamy babu budumuru
>
>
Re: Review Request: CLOUDSTACK-1429: single account is unable to use same
vnet across multiple physical networks
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9651/#review17399
-----------------------------------------------------------
Ship it!
Pushed to 4.1 branch. Please update the bug to set to resolved.
commit 17e3313e694940efb97eb4aadec336869c24022d
Author: Venkata Swamybabu Budumuru <ve...@citrix.com>
Date: Wed Feb 27 13:37:41 2013 -0500
Accounts can hold multiple vnets. Same vnets can exist across multiple pnets. It is sufficient to constrain a single vnet in a given pnet within a datacenter. `i_op_dc_vnet_alloc__vnet__data_center_id` covers all use cases for the table.
Having `i_op_dc_vnet_alloc__vnet__data_center_id__account_id` will restrict
same account holding the same vnet across different physical networks.
Signed-off-by: Venkata Swamybabu Budumuru <ve...@citrix.com>
- Chip Childers
On March 5, 2013, 1:31 p.m., venkata swamy babu budumuru wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9651/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 1:31 p.m.)
>
>
> Review request for cloudstack, Chip Childers and Marcus Sorensen.
>
>
> Description
> -------
>
> to repro
>
> (1) Have an advanced zone with physical networks say Phynet1: 900-905 Phynet2: 905-909
> (2) create a Network in physical network1 (id : 200) and deploy a vm (for ex:- network created is using vlan 905 )
> (3) create another network in physical network2 (id : 201) and deploy a vm
>
> Observations :
>
> (i) It tried to pick up vlan 905 from physical network 2 (id : 201) and it failed with the following error.
>
> Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Duplicate entry '905-1-3' for key 'i_op_dc_vnet_alloc__vnet__data_center_id__account_id'
>
> Attached patch fixes the issue.
>
>
> This addresses bug CLOUDSTACK-1429.
>
>
> Diffs
> -----
>
> setup/db/db/schema-40to410.sql 59b2a7d
>
> Diff: https://reviews.apache.org/r/9651/diff/
>
>
> Testing
> -------
>
> Retried the scenario with the dropped index and it works successfully.
>
>
> Thanks,
>
> venkata swamy babu budumuru
>
>
Re: Review Request: CLOUDSTACK-1429: single account is unable to use same
vnet across multiple physical networks
Posted by venkata swamy babu budumuru <ve...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9651/
-----------------------------------------------------------
(Updated March 5, 2013, 1:31 p.m.)
Review request for cloudstack, Chip Childers and Marcus Sorensen.
Changes
-------
Chip,
Can you please add this code to 4.1?
Thanks,
SWAMY
Description
-------
to repro
(1) Have an advanced zone with physical networks say Phynet1: 900-905 Phynet2: 905-909
(2) create a Network in physical network1 (id : 200) and deploy a vm (for ex:- network created is using vlan 905 )
(3) create another network in physical network2 (id : 201) and deploy a vm
Observations :
(i) It tried to pick up vlan 905 from physical network 2 (id : 201) and it failed with the following error.
Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Duplicate entry '905-1-3' for key 'i_op_dc_vnet_alloc__vnet__data_center_id__account_id'
Attached patch fixes the issue.
This addresses bug CLOUDSTACK-1429.
Diffs
-----
setup/db/db/schema-40to410.sql 59b2a7d
Diff: https://reviews.apache.org/r/9651/diff/
Testing
-------
Retried the scenario with the dropped index and it works successfully.
Thanks,
venkata swamy babu budumuru
Re: Review Request: CLOUDSTACK-1429: single account is unable to use same
vnet across multiple physical networks
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9651/#review17387
-----------------------------------------------------------
Ship it!
commit 5b8f0791ec15efd6a77f581a62dde9960d06102c
- Kishan Kavala
On Feb. 27, 2013, 1:53 p.m., venkata swamy babu budumuru wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9651/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2013, 1:53 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Description
> -------
>
> to repro
>
> (1) Have an advanced zone with physical networks say Phynet1: 900-905 Phynet2: 905-909
> (2) create a Network in physical network1 (id : 200) and deploy a vm (for ex:- network created is using vlan 905 )
> (3) create another network in physical network2 (id : 201) and deploy a vm
>
> Observations :
>
> (i) It tried to pick up vlan 905 from physical network 2 (id : 201) and it failed with the following error.
>
> Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Duplicate entry '905-1-3' for key 'i_op_dc_vnet_alloc__vnet__data_center_id__account_id'
>
> Attached patch fixes the issue.
>
>
> This addresses bug CLOUDSTACK-1429.
>
>
> Diffs
> -----
>
> setup/db/db/schema-40to410.sql 59b2a7d
>
> Diff: https://reviews.apache.org/r/9651/diff/
>
>
> Testing
> -------
>
> Retried the scenario with the dropped index and it works successfully.
>
>
> Thanks,
>
> venkata swamy babu budumuru
>
>