You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by pa...@apache.org on 2022/02/14 06:10:20 UTC

[beam] branch master updated: [BEAM-13775] Fixed bug with run button

This is an automated email from the ASF dual-hosted git repository.

pabloem pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 9f033e0  [BEAM-13775] Fixed bug with run button
     new c29f1b5  Merge pull request #16821 from [BEAM-13775] [Playground] Run button after start of the processing and move output tab
9f033e0 is described below

commit 9f033e0048f189f832468d93d2f526ddefd2852a
Author: Alexander <al...@akvelon.com>
AuthorDate: Fri Feb 11 15:01:44 2022 +0400

    [BEAM-13775] Fixed bug with run button
---
 .../lib/pages/playground/components/editor_textarea_wrapper.dart      | 4 +++-
 playground/frontend/lib/pages/playground/states/playground_state.dart | 4 +---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/playground/frontend/lib/pages/playground/components/editor_textarea_wrapper.dart b/playground/frontend/lib/pages/playground/components/editor_textarea_wrapper.dart
index d854ad9..c7182dd 100644
--- a/playground/frontend/lib/pages/playground/components/editor_textarea_wrapper.dart
+++ b/playground/frontend/lib/pages/playground/components/editor_textarea_wrapper.dart
@@ -83,10 +83,12 @@ class CodeTextAreaWrapper extends StatelessWidget {
                               );
                         },
                         runCode: () {
+                          AnalyticsService analyticsService =
+                              AnalyticsService.get(context);
                           final stopwatch = Stopwatch()..start();
                           state.runCode(
                             onFinish: () {
-                              AnalyticsService.get(context).trackRunTimeEvent(
+                              analyticsService.trackRunTimeEvent(
                                 state.selectedExample?.path ??
                                     '${AppLocalizations.of(context)!.unknownExample}, sdk ${state.sdk.displayName}',
                                 stopwatch.elapsedMilliseconds,
diff --git a/playground/frontend/lib/pages/playground/states/playground_state.dart b/playground/frontend/lib/pages/playground/states/playground_state.dart
index d9e612e..f62bc42 100644
--- a/playground/frontend/lib/pages/playground/states/playground_state.dart
+++ b/playground/frontend/lib/pages/playground/states/playground_state.dart
@@ -213,11 +213,9 @@ class PlaygroundState with ChangeNotifier {
       timer = Timer.periodic(timerInterval, tick);
     }
 
-    streamController = StreamController<int>(
+    streamController = StreamController<int>.broadcast(
       onListen: startTimer,
       onCancel: stopTimer,
-      onResume: startTimer,
-      onPause: stopTimer,
     );
 
     return streamController;