You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/08/16 05:47:49 UTC
[GitHub] [submarine] jeff-901 opened a new pull request #712: SUBMARINE-978. Add model management database service.
jeff-901 opened a new pull request #712:
URL: https://github.com/apache/submarine/pull/712
### What is this PR for?
Create model service for later serving and other model management REST api.
### What type of PR is it?
Feature
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-978
### How should this be tested?
Call the model service api and see the difference on the mlflow UI.
If you test locally edit the jdbc url ip address in ModelBatisUtil.java and modelbatis-config.xml.
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #712: SUBMARINE-978. Add model management database service.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #712:
URL: https://github.com/apache/submarine/pull/712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] jeff-901 commented on a change in pull request #712: SUBMARINE-978. Add model management database service.
Posted by GitBox <gi...@apache.org>.
jeff-901 commented on a change in pull request #712:
URL: https://github.com/apache/submarine/pull/712#discussion_r689947605
##########
File path: submarine-server/server-core/src/main/resources/org/apache/submarine/database/mappers/ModelVersionMapper.xml
##########
@@ -0,0 +1,75 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+<!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN" "http://mybatis.org/dtd/mybatis-3-mapper.dtd">
+<mapper namespace="org.apache.submarine.server.model.database.mappers.ModelVersionMapper">
+ <resultMap id="resultMap" type="org.apache.submarine.server.model.database.entities.ModelVersionEntity">
+ <result column="name" property="name" />
+ <result column="version" property="version" />
+ <result column="creation_time" property="createTime" />
+ <result column="last_updated_time" property="lastUpdatedTime" />
+ <result column="description" property="description" />
+ <result column="user_id" property="userId" />
+ <result column="current_stage" property="currentStage" />
+ <result column="source" property="source" />
+ <result column="run_id" property="runId" />
+ <result column="status" property="status" />
+ <result column="status_message" property="statusMessage" />
Review comment:
@KUAN-HSUN-LI `current_stage` indicates the model is Staging, Production or Archived. `status` shows whether the model is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] jeff-901 commented on a change in pull request #712: SUBMARINE-978. Add model management database service.
Posted by GitBox <gi...@apache.org>.
jeff-901 commented on a change in pull request #712:
URL: https://github.com/apache/submarine/pull/712#discussion_r689947691
##########
File path: submarine-server/server-core/src/main/resources/org/apache/submarine/database/mappers/ModelVersionMapper.xml
##########
@@ -0,0 +1,75 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+<!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN" "http://mybatis.org/dtd/mybatis-3-mapper.dtd">
+<mapper namespace="org.apache.submarine.server.model.database.mappers.ModelVersionMapper">
+ <resultMap id="resultMap" type="org.apache.submarine.server.model.database.entities.ModelVersionEntity">
+ <result column="name" property="name" />
+ <result column="version" property="version" />
+ <result column="creation_time" property="createTime" />
+ <result column="last_updated_time" property="lastUpdatedTime" />
+ <result column="description" property="description" />
+ <result column="user_id" property="userId" />
+ <result column="current_stage" property="currentStage" />
+ <result column="source" property="source" />
+ <result column="run_id" property="runId" />
+ <result column="status" property="status" />
+ <result column="status_message" property="statusMessage" />
Review comment:
@KUAN-HSUN-LI `current_stage` indicates the model is Staging, Production or Archived. `status` shows whether the model is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] KUAN-HSUN-LI commented on a change in pull request #712: SUBMARINE-978. Add model management database service.
Posted by GitBox <gi...@apache.org>.
KUAN-HSUN-LI commented on a change in pull request #712:
URL: https://github.com/apache/submarine/pull/712#discussion_r689735596
##########
File path: submarine-server/server-core/src/main/resources/org/apache/submarine/database/mappers/ModelVersionMapper.xml
##########
@@ -0,0 +1,75 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+<!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN" "http://mybatis.org/dtd/mybatis-3-mapper.dtd">
+<mapper namespace="org.apache.submarine.server.model.database.mappers.ModelVersionMapper">
+ <resultMap id="resultMap" type="org.apache.submarine.server.model.database.entities.ModelVersionEntity">
+ <result column="name" property="name" />
+ <result column="version" property="version" />
+ <result column="creation_time" property="createTime" />
+ <result column="last_updated_time" property="lastUpdatedTime" />
+ <result column="description" property="description" />
+ <result column="user_id" property="userId" />
+ <result column="current_stage" property="currentStage" />
+ <result column="source" property="source" />
+ <result column="run_id" property="runId" />
+ <result column="status" property="status" />
+ <result column="status_message" property="statusMessage" />
Review comment:
@jeff-901 I am confused with `current_stage` and `status`. What is the difference between these two data? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] jeff-901 commented on pull request #712: SUBMARINE-978. Add model management database service.
Posted by GitBox <gi...@apache.org>.
jeff-901 commented on pull request #712:
URL: https://github.com/apache/submarine/pull/712#issuecomment-899240760
@ByronHsu @KUAN-HSUN-LI help me review the code. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] KUAN-HSUN-LI commented on a change in pull request #712: SUBMARINE-978. Add model management database service.
Posted by GitBox <gi...@apache.org>.
KUAN-HSUN-LI commented on a change in pull request #712:
URL: https://github.com/apache/submarine/pull/712#discussion_r689957296
##########
File path: submarine-server/server-core/src/main/resources/org/apache/submarine/database/mappers/ModelVersionMapper.xml
##########
@@ -0,0 +1,75 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+<!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN" "http://mybatis.org/dtd/mybatis-3-mapper.dtd">
+<mapper namespace="org.apache.submarine.server.model.database.mappers.ModelVersionMapper">
+ <resultMap id="resultMap" type="org.apache.submarine.server.model.database.entities.ModelVersionEntity">
+ <result column="name" property="name" />
+ <result column="version" property="version" />
+ <result column="creation_time" property="createTime" />
+ <result column="last_updated_time" property="lastUpdatedTime" />
+ <result column="description" property="description" />
+ <result column="user_id" property="userId" />
+ <result column="current_stage" property="currentStage" />
+ <result column="source" property="source" />
+ <result column="run_id" property="runId" />
+ <result column="status" property="status" />
+ <result column="status_message" property="statusMessage" />
Review comment:
@jeff-901 Thanks for your explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org