You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/20 16:34:55 UTC

[GitHub] [spark] MaxGekk commented on a change in pull request #27643: [SPARK-30886][SQL] Warn two-parameter TRIM/LTRIM/RTRIM function usages

MaxGekk commented on a change in pull request #27643: [SPARK-30886][SQL] Warn two-parameter TRIM/LTRIM/RTRIM function usages
URL: https://github.com/apache/spark/pull/27643#discussion_r382116735
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ##########
 @@ -1793,6 +1794,7 @@ class Analyzer(
    * Replaces [[UnresolvedFunction]]s with concrete [[Expression]]s.
    */
   object ResolveFunctions extends Rule[LogicalPlan] {
+    val trimWarningEnabled = new AtomicBoolean(true)
 
 Review comment:
   When do you set it back to `true`? The `ResolveFunctions` object can live forever. By setting it to `false` only once, you disable warnings for all apps and users.
   
   Let's image multiple notebooks connected to the same cluster - they will share the same `trimWarningEnabled` if I am not wrong.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org