[jira] [Updated] (SOLR-4931) Override exact signatures (with generics) in SolrDeletionPolicy

["Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar updated SOLR-4931:
----------------------------------------

    Attachment: SOLR-4931.patch

Changed SolrDeletionPolicy onInit and onCommit to use the exact generic params as the parent. All tests pass. I'll commit shortly.
                
> Override exact signatures (with generics) in SolrDeletionPolicy
> ---------------------------------------------------------------
>
>                 Key: SOLR-4931
>                 URL: https://issues.apache.org/jira/browse/SOLR-4931
>             Project: Solr
>          Issue Type: Task
>    Affects Versions: 4.3
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 4.4
>
>         Attachments: SOLR-4931.patch
>
>
> LUCENE-4876 changed the IndexDeletionPolicy to an abstract class. The SolrDeletionPolicy extends this class but overrides the onInit and onCommit methods with non generic parameters. This makes people who extend SolrDeletionPolicy (even though we don't recommend doing that) run into a Java6 bug:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6775192
> The workaround is to use reflection to call the parent class's method.  I propose  that we change SolrDeletionPolicy to override parent's methods with the exact signature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org