Re: [PR] [FLINK-33689][table-runtime] Fix JsonObjectAggFunction can't retract records when enabling LocalGlobal. [flink]

["xishuaidelin (via GitHub)" <gi...@apache.org>]

xishuaidelin commented on code in PR #23827:
URL: https://github.com/apache/flink/pull/23827#discussion_r1451985731


##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/aggregate/JsonObjectAggFunction.java:
##########
@@ -128,6 +137,15 @@ public void merge(Accumulator acc, Iterable<Accumulator> others) throws Exceptio
                 assertKeyNotPresent(acc, key);
                 acc.map.put(key, other.map.get(key));
             }
+            for (final StringData key : other.retractMap.keys()) {

Review Comment:
   Hi xuyang, thanks for your comments. It considers both the key and the corresponding value in the comparison. Therefore, I don't foresee any issues arising during the merge stage. However, the issue you mentioned could potentially occur at the local stage, such as within the retract function. I would fix it in retract function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org