You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/30 01:55:20 UTC
[GitHub] [airflow] MrSandoman opened a new issue #16725: filesensor
MrSandoman opened a new issue #16725:
URL: https://github.com/apache/airflow/issues/16725
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>
Please delete these comment blocks before submitting the issue.
-->
<!--
IMPORTANT!!!
PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
Please complete the next sections or the issue will be closed.
These questions are the first thing we need to know to understand the context.
-->
**Apache Airflow version**:
**Kubernetes version (if you are using kubernetes)** (use `kubectl version`):
**Environment**:
- **Cloud provider or hardware configuration**:
- **OS** (e.g. from /etc/os-release):
- **Kernel** (e.g. `uname -a`):
- **Install tools**:
- **Others**:
**What happened**:
<!-- (please include exact error messages if you can) -->
**What you expected to happen**:
<!-- What do you think went wrong? -->
**How to reproduce it**:
<!---
As minimally and precisely as possible. Keep in mind we do not have access to your cluster or dags.
If you are using kubernetes, please attempt to recreate the issue using minikube or kind.
## Install minikube/kind
- Minikube https://minikube.sigs.k8s.io/docs/start/
- Kind https://kind.sigs.k8s.io/docs/user/quick-start/
If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action
You can include images using the .md style of
To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.
--->
**Anything else we need to know**:
<!--
How often does this problem occur? Once? Every time etc?
Any relevant logs to include? Put them here in side a detail tag:
<details><summary>x.log</summary> lots of stuff </details>
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] MrSandoman commented on issue #16725: filesensor wildcard matching does not recognize directories
Posted by GitBox <gi...@apache.org>.
MrSandoman commented on issue #16725:
URL: https://github.com/apache/airflow/issues/16725#issuecomment-871640619
I can open a PR for the quick fix to substitute path for full_path in the walk, but I'm not very familiar with `pathlib.Path.glob()` to be able to make that change in the logic. Also never submitted a PR to a big project like Airflow before (pretty new to coding in general) so gotta go figure out that process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #16725: filesensor wildcard matching does not recognize directories
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #16725:
URL: https://github.com/apache/airflow/issues/16725#issuecomment-871434657
We should change the logic to use `pathlib.Path.glob()` instead, which automatically handles recursive globbing. (Or `glob.rglob()` but pathlib is easier to use IMO.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #16725: filesensor wildcard matching does not recognize directories
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #16725:
URL: https://github.com/apache/airflow/issues/16725#issuecomment-876711134
Running now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #16725: filesensor wildcard matching does not recognize directories
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #16725:
URL: https://github.com/apache/airflow/issues/16725#issuecomment-871706111
Hmm, after reading the relevant code, `pathlib.Path.glob()` might not be the best choice. It’s easier to do `glob(full_path, recursive=True)` instead. So you’ll need to do that. After that, please follow the instructions in https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst to submit a pull request for your change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ShraddheyaS edited a comment on issue #16725: filesensor wildcard matching does not recognize directories
Posted by GitBox <gi...@apache.org>.
ShraddheyaS edited a comment on issue #16725:
URL: https://github.com/apache/airflow/issues/16725#issuecomment-876699419
@uranusjr I have opened a PR https://github.com/apache/airflow/pull/16894 for resolving this using the `recursive=True` fix you mention above. Also verified with the new test added that the fix works (as expected, the test fails without the flag).
As a first time contributor, a workflow in the CICD pipeline is blocked on the PR. ~~Can you please approve the workflow?~~ Looks like it is triggered. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] 0sunny commented on issue #16725: filesensor wildcard matching does not recognize directories
Posted by GitBox <gi...@apache.org>.
0sunny commented on issue #16725:
URL: https://github.com/apache/airflow/issues/16725#issuecomment-877353511
Can you please assign this to me ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed issue #16725: filesensor wildcard matching does not recognize directories
Posted by GitBox <gi...@apache.org>.
kaxil closed issue #16725:
URL: https://github.com/apache/airflow/issues/16725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ShraddheyaS commented on issue #16725: filesensor wildcard matching does not recognize directories
Posted by GitBox <gi...@apache.org>.
ShraddheyaS commented on issue #16725:
URL: https://github.com/apache/airflow/issues/16725#issuecomment-876699419
@uranusjr I have opened a PR https://github.com/apache/airflow/pull/16894 for resolving this using the `recursive=True` fix you mention above. Also verified with the new test added that the fix works (as expected, the test fails without the flag).
As a first time contributor, a workflow in the CICD pipeline is blocked on the PR. Can you please approve the workflow? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #16725: filesensor wildcard matching does not recognize directories
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #16725:
URL: https://github.com/apache/airflow/issues/16725#issuecomment-871147952
Would you be willing to open PR for that ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #16725: filesensor
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #16725:
URL: https://github.com/apache/airflow/issues/16725#issuecomment-871038084
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org