You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/03/01 06:41:14 UTC
[GitHub] jvrao commented on a change in pull request #1218: Support LacPiggyback, LongPoll and ExplicitLac in db ledger storage
jvrao commented on a change in pull request #1218: Support LacPiggyback, LongPoll and ExplicitLac in db ledger storage
URL: https://github.com/apache/bookkeeper/pull/1218#discussion_r171473950
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java
##########
@@ -242,10 +242,13 @@ public long getLastAddConfirmed(long ledgerId) throws IOException {
if (null == bb) {
return BookieProtocol.INVALID_ENTRY_ID;
} else {
- bb.readLong(); // ledger id
- bb.readLong(); // entry id
- lac = bb.readLong();
- lac = ledgerCache.updateLastAddConfirmed(ledgerId, lac);
+ try {
+ bb.skipBytes(2 * Long.BYTES); // skip ledger & entry id
+ lac = bb.readLong();
+ lac = ledgerCache.updateLastAddConfirmed(ledgerId, lac);
+ } finally {
+ bb.release();
Review comment:
Leak in existing code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services