You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by robertamarton <gi...@git.apache.org> on 2015/10/22 01:10:34 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-1551] Changed version...
GitHub user robertamarton opened a pull request:
https://github.com/apache/incubator-trafodion/pull/141
[TRAFODION-1551] Changed version of Trafodion from 1.2.0 to 1.3.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertamarton/incubator-trafodion testb
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/141.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #141
----
commit 288a33781c8bbcaa58c9e49975ec77bba5a29797
Author: Roberta Marton <ro...@esgyn.com>
Date: 2015-10-21T23:06:37Z
Trafodion-1551 -- Change version of Trafodion from 1.2.0 to 1.3.0
Changed Trafodion version from 1.2.0 to 1.3.0 as requested by the release
team.
Reworded text in sqenvcom.sh to better reflect the operation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1551] Changed version...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/141#discussion_r42893317
--- Diff: core/sqf/sqenvcom.sh ---
@@ -469,24 +469,24 @@ else
cat <<EOF
- If you have Apache Hadoop and HBase installed, without a distro,
- please do the following to ensure Trafodion can find the installation
+ If you are ready to build Trafodion, perform one of the following options:
- Method 1: Ensure that hadoop-site.xml, hbase-site.xml and hive-site.xml
- are in the CLASSPATH.
+ make all (Build Trafodion, DCS, and REST) OR
+ make package (Build Trafodion, DCS, REST, and Client drivers) OR
+ make package-all (Build Trafodion, DCS, REST, Client drivers, and Tests)
- Method 2: Set the following environment variables:
- - HADOOP_PREFIX for Hadoop (example: /opt/hadoop-1.2.3)
- - HBASE_HOME for HBase (example: /opt/hbase-1.2.3)
- - HIVE_HOME for Hive (example: /opt/hive-1.2.3)
+ If Trafodion has been built and you want test:
- See http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/ClusterSetup.html
+ Execute the install_local_hadoop script which performs a single node
+ install using a popular Hadoop distribution
- Yet another option is to use the install_local_hadoop script on a
- single node for evaluation or development.
+ cd $MY_SQROOT/sql/scripts
+ install_local_hadoop [-p <port option]
--- End diff --
Missing ">" after "<port option". Can fix it later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1551] Changed version...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/141
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1551] Changed version...
Posted by svarnau <gi...@git.apache.org>.
Github user svarnau commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/141#discussion_r42772243
--- Diff: core/sqf/sql/scripts/install_local_hadoop ---
@@ -1534,7 +1534,7 @@ fi
cd $MY_SW_ROOT
-if [ ! -r $YARN_HOME/lib/native/libhdfs.so ]; then
+if [ -d $MY_LOCAL_SW_DIST && ! -r $YARN_HOME/lib/native/libhdfs.so ]; then
echo "------------------------------------------------------------"
echo "-- WARNING: libhdfs.so is not present on this system. Please"
echo "-- build it, otherwise Trafodion will not compile."
--- End diff --
I thought libhdfs dependency is now built if not found, so this message is obsolete now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1551] Changed version...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/141#discussion_r42893404
--- Diff: core/sqf/sqenvcom.sh ---
@@ -469,24 +469,24 @@ else
cat <<EOF
- If you have Apache Hadoop and HBase installed, without a distro,
- please do the following to ensure Trafodion can find the installation
+ If you are ready to build Trafodion, perform one of the following options:
- Method 1: Ensure that hadoop-site.xml, hbase-site.xml and hive-site.xml
- are in the CLASSPATH.
+ make all (Build Trafodion, DCS, and REST) OR
+ make package (Build Trafodion, DCS, REST, and Client drivers) OR
+ make package-all (Build Trafodion, DCS, REST, Client drivers, and Tests)
- Method 2: Set the following environment variables:
- - HADOOP_PREFIX for Hadoop (example: /opt/hadoop-1.2.3)
- - HBASE_HOME for HBase (example: /opt/hbase-1.2.3)
- - HIVE_HOME for Hive (example: /opt/hive-1.2.3)
+ If Trafodion has been built and you want test:
- See http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/ClusterSetup.html
+ Execute the install_local_hadoop script which performs a single node
+ install using a popular Hadoop distribution
- Yet another option is to use the install_local_hadoop script on a
- single node for evaluation or development.
+ cd $MY_SQROOT/sql/scripts
+ install_local_hadoop [-p <port option]
+ source ./install_traf_components
+ configure Trafodion and start the processes
+ HAVE FUN!
- If you just checked out or copied a Trafodion source tree and want to build,
- then you can ignore the above and continue with your build.
+ You can also choose to install_local_hadoop before building Trafodion
--- End diff --
Missing the end of the sentence? Or just a period?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1551] Changed version...
Posted by robertamarton <gi...@git.apache.org>.
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/141#discussion_r42791691
--- Diff: core/sqf/sql/scripts/install_local_hadoop ---
@@ -1534,7 +1534,7 @@ fi
cd $MY_SW_ROOT
-if [ ! -r $YARN_HOME/lib/native/libhdfs.so ]; then
+if [ -d $MY_LOCAL_SW_DIST && ! -r $YARN_HOME/lib/native/libhdfs.so ]; then
echo "------------------------------------------------------------"
echo "-- WARNING: libhdfs.so is not present on this system. Please"
echo "-- build it, otherwise Trafodion will not compile."
--- End diff --
The libhdfs library is needed at both build and run time. The way we have things setup, we should be creating this directory at build time, and copying the file at run time. There may be a situation where somehow the library goes missing. To avoid confusion to people who are trying out the product and should follow the build instructions from those who actually maintain this script, I will leave the message in but only display it if VERBOSE is enabled. During debugging, if someone is having issue, then this information maybe useful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1551] Changed version...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/141#discussion_r42893347
--- Diff: core/sqf/sqenvcom.sh ---
@@ -469,24 +469,24 @@ else
cat <<EOF
- If you have Apache Hadoop and HBase installed, without a distro,
- please do the following to ensure Trafodion can find the installation
+ If you are ready to build Trafodion, perform one of the following options:
- Method 1: Ensure that hadoop-site.xml, hbase-site.xml and hive-site.xml
- are in the CLASSPATH.
+ make all (Build Trafodion, DCS, and REST) OR
+ make package (Build Trafodion, DCS, REST, and Client drivers) OR
+ make package-all (Build Trafodion, DCS, REST, Client drivers, and Tests)
- Method 2: Set the following environment variables:
- - HADOOP_PREFIX for Hadoop (example: /opt/hadoop-1.2.3)
- - HBASE_HOME for HBase (example: /opt/hbase-1.2.3)
- - HIVE_HOME for Hive (example: /opt/hive-1.2.3)
+ If Trafodion has been built and you want test:
- See http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/ClusterSetup.html
+ Execute the install_local_hadoop script which performs a single node
+ install using a popular Hadoop distribution
- Yet another option is to use the install_local_hadoop script on a
- single node for evaluation or development.
+ cd $MY_SQROOT/sql/scripts
+ install_local_hadoop [-p <port option]
+ source ./install_traf_components
+ configure Trafodion and start the processes
+ HAVE FUN!
--- End diff --
Amen! Tell it, sister.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---