You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2023/06/29 02:16:51 UTC
[GitHub] [pinot] Jackie-Jiang opened a new pull request, #10999: Fix flaky MultiNodesOfflineClusterIntegrationTest.testServerHardFailure()
Jackie-Jiang opened a new pull request, #10999:
URL: https://github.com/apache/pinot/pull/10999
Got another possible exception message, so removed the message check as it is not important
```
MultiNodesOfflineClusterIntegrationTest.testServerHardFailure:150->testCountStarQuery:183 Got unexpected first exception message: java.lang.RuntimeException: Channel for server: localhost_O is inactive
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10999: Fix flaky MultiNodesOfflineClusterIntegrationTest.testServerHardFailure()
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #10999:
URL: https://github.com/apache/pinot/pull/10999#discussion_r1247142202
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiNodesOfflineClusterIntegrationTest.java:
##########
@@ -178,11 +178,12 @@ private void testCountStarQuery(int expectedNumServersQueried, boolean exception
JsonNode exceptions = queryResult.get("exceptions");
assertEquals(exceptions.size(), 2);
JsonNode firstException = exceptions.get(0);
+ // NOTE:
+ // Only verify the error code but not the exception message because there can be different messages:
+ // - Connection refused
+ // - Connection reset
+ // - Channel is inactive
assertEquals(firstException.get("errorCode").intValue(), QueryException.BROKER_REQUEST_SEND_ERROR_CODE);
- String firstExceptionMessage = firstException.get("message").textValue();
- assertTrue(
- firstExceptionMessage.contains("Connection refused") || firstExceptionMessage.contains("Connection reset"),
- "Got unexpected first exception message: " + firstExceptionMessage);
Review Comment:
The message itself is not that important, and is from a third-party library, so ignoring the actual content should be fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] shenyu0127 commented on a diff in pull request #10999: Fix flaky MultiNodesOfflineClusterIntegrationTest.testServerHardFailure()
Posted by "shenyu0127 (via GitHub)" <gi...@apache.org>.
shenyu0127 commented on code in PR #10999:
URL: https://github.com/apache/pinot/pull/10999#discussion_r1246133357
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiNodesOfflineClusterIntegrationTest.java:
##########
@@ -178,11 +178,12 @@ private void testCountStarQuery(int expectedNumServersQueried, boolean exception
JsonNode exceptions = queryResult.get("exceptions");
assertEquals(exceptions.size(), 2);
JsonNode firstException = exceptions.get(0);
+ // NOTE:
+ // Only verify the error code but not the exception message because there can be different messages:
+ // - Connection refused
+ // - Connection reset
+ // - Channel is inactive
assertEquals(firstException.get("errorCode").intValue(), QueryException.BROKER_REQUEST_SEND_ERROR_CODE);
- String firstExceptionMessage = firstException.get("message").textValue();
- assertTrue(
- firstExceptionMessage.contains("Connection refused") || firstExceptionMessage.contains("Connection reset"),
- "Got unexpected first exception message: " + firstExceptionMessage);
Review Comment:
You are not adding `|| firstExceptionMessage.contains("inactive")` here, is it because there might be other exception messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10999: Fix flaky MultiNodesOfflineClusterIntegrationTest.testServerHardFailure()
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10999:
URL: https://github.com/apache/pinot/pull/10999#issuecomment-1612362553
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10999?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10999](https://app.codecov.io/gh/apache/pinot/pull/10999?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (78aad69) into [master](https://app.codecov.io/gh/apache/pinot/commit/ed4774c5d95b3975a72295e52268c47b3e9819fe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ed4774c) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #10999 +/- ##
=========================================
Coverage 0.11% 0.11%
=========================================
Files 2191 2137 -54
Lines 118001 115496 -2505
Branches 17867 17565 -302
=========================================
Hits 137 137
+ Misses 117844 115339 -2505
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin20 | `?` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `?` | |
| unittests1temurin11 | `?` | |
| unittests1temurin17 | `?` | |
| unittests2temurin11 | `?` | |
| unittests2temurin17 | `?` | |
| unittests2temurin20 | `0.11% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 56 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10999/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10999: Fix flaky MultiNodesOfflineClusterIntegrationTest.testServerHardFailure()
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10999:
URL: https://github.com/apache/pinot/pull/10999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org