You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/02/07 22:49:00 UTC
Review Request 56411: SENTRY-1624 DefaultSentryValidator doesn't
correctly construct SentryOnFailureHookContextImpl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56411/
-----------------------------------------------------------
Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Nachiket Vaidya, and Vamsee Yarlagadda.
Bugs: SENTRY-1624
https://issues.apache.org/jira/browse/SENTRY-1624
Repository: sentry
Description
-------
SENTRY-1624 DefaultSentryValidator doesn't correctly construct SentryOnFailureHookContextImpl
Diffs
-----
sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryValidator.java c9da3ab0a901095acc0d78ce2ed0da0f0038ee56
Diff: https://reviews.apache.org/r/56411/diff/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 56411: SENTRY-1624 DefaultSentryValidator doesn't
correctly construct SentryOnFailureHookContextImpl
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On Feb. 7, 2017, 11:01 p.m., Nachiket Vaidya wrote:
> > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryValidator.java, line 212
> > <https://reviews.apache.org/r/56411/diff/1/?file=1626950#file1626950line212>
> >
> > Is sending empty list better than sending null list for List<AccessURI>? Do we have test cases which exercise this path? Did those pass?
I didn't see any consumers of the data. I don't think we have any test cases for this.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56411/#review164577
-----------------------------------------------------------
On Feb. 8, 2017, 12:53 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56411/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 12:53 a.m.)
>
>
> Review request for sentry, Aihua Xu, Hao Hao, kalyan kumar kalvagadda, Nachiket Vaidya, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1624
> https://issues.apache.org/jira/browse/SENTRY-1624
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1624 DefaultSentryValidator doesn't correctly construct SentryOnFailureHookContextImpl
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryValidator.java c9da3ab0a901095acc0d78ce2ed0da0f0038ee56
>
> Diff: https://reviews.apache.org/r/56411/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 56411: SENTRY-1624 DefaultSentryValidator doesn't
correctly construct SentryOnFailureHookContextImpl
Posted by Nachiket Vaidya <nv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56411/#review164577
-----------------------------------------------------------
sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryValidator.java (line 210)
<https://reviews.apache.org/r/56411/#comment236345>
Is sending empty list better than sending null list for List<AccessURI>? Do we have test cases which exercise this path? Did those pass?
- Nachiket Vaidya
On Feb. 7, 2017, 10:49 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56411/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 10:49 p.m.)
>
>
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Nachiket Vaidya, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1624
> https://issues.apache.org/jira/browse/SENTRY-1624
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1624 DefaultSentryValidator doesn't correctly construct SentryOnFailureHookContextImpl
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryValidator.java c9da3ab0a901095acc0d78ce2ed0da0f0038ee56
>
> Diff: https://reviews.apache.org/r/56411/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>