Re: [PR] GUACAMOLE-2123: Fix remote app render issues. Use per-window guac_dis… [guacamole-server]

["necouchman (via GitHub)" <gi...@apache.org>]

necouchman commented on code in PR #673:
URL: https://github.com/apache/guacamole-server/pull/673#discussion_r3413614850


##########
src/protocols/rdp/channels/rail.c:
##########
@@ -37,6 +48,332 @@
 #include <stddef.h>
 #include <string.h>
 
+/*
+ * RemoteApp (RAIL) with the RDPGFX pipeline.
+ *
+ * When both RAIL and GFX are active, the RDP server delivers per-window
+ * graphical updates as RDPGFX surfaces tagged with a non-zero windowId
+ * (gdiGfxSurface->windowId). The default GDI graphics pipeline only knows how
+ * to paint into a single primary desktop buffer, so without intervention these
+ * window-mapped surfaces are silently dropped on the floor.
+ *
+ * This module tracks each RAIL window with its own guac_display_layer,
+ * positioned by the RAIL window-order stream and painted from the corresponding
+ * RDPGFX surface via either:
+ *
+ *   - UpdateSurfaceArea (fallback for older FreeRDP without the window
+ *     callback; called with rect lists for any surface update).
+ *
+ *   - UpdateWindowFromSurface, when available.
+ */
+
+typedef struct guac_rdp_rail_window {

Review Comment:
   This `guac_rdp_rail_window` struct needs a comment describing it, it's purpose, etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org