You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/06/07 20:01:51 UTC

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3627: Removed restangular from RegexService

mitchell852 commented on a change in pull request #3627: Removed restangular from RegexService
URL: https://github.com/apache/trafficcontrol/pull/3627#discussion_r291735335
 
 

 ##########
 File path: traffic_portal/app/src/common/api/RegexService.js
 ##########
 @@ -17,13 +17,21 @@
  * under the License.
  */
 
-var RegexService = function(Restangular, locationUtils, messageModel) {
+var RegexService = function($http, ENV) {
 
+	// This appears to never be used - and I don't think it works anyway.
 
 Review comment:
   you are right. this service is not used anywhere. can you delete it instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services