You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by John Nicol <ni...@gmail.com> on 2006/05/17 18:41:27 UTC
"svn log --limit" argument bug
Hi there,
"svn log --limit 0" and "svn log --limit -5" both seem to do something,
although I haven't seen any output from them.
I believe both of these should return a syntax error, similar to:
c:\temp> svn log -r -1
svn: Syntax error in revision argument '-1'
Thanks,
John
Re: "svn log --limit" argument bug
Posted by John Nicol <ni...@gmail.com>.
Thanks for the feedback! Filed as issue 2552 with the below comments.
John
On 5/17/06, Peter N. Lundblad <pe...@famlundblad.se> wrote:
>
> David James writes:
> > On 5/17/06, Garrett Rooney < rooneg@electricjellyfish.net> wrote:
> > > > "svn log --limit 0" and "svn log --limit -5" both seem to do
> something,
> > > > although I haven't seen any output from them.
> > > > I believe both of these should return a syntax error, similar to:
> > > >
> > > > c:\temp> svn log -r -1
> > > > svn: Syntax error in revision argument '-1'
> > >
> > > Makes sense to me. Got a patch?
> >
> > svn log --limit 0 displays all revisions. This makes sense, as "0"
> > means that there is no limit at all.
> >
> Since 0 != infinity, I think this should stay as an internal
> implementation
> detail. :-)
>
> Regards,
> //Peter
>
Re: "svn log --limit" argument bug
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
David James writes:
> On 5/17/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> > > "svn log --limit 0" and "svn log --limit -5" both seem to do something,
> > > although I haven't seen any output from them.
> > > I believe both of these should return a syntax error, similar to:
> > >
> > > c:\temp> svn log -r -1
> > > svn: Syntax error in revision argument '-1'
> >
> > Makes sense to me. Got a patch?
>
> svn log --limit 0 displays all revisions. This makes sense, as "0"
> means that there is no limit at all.
>
Since 0 != infinity, I think this should stay as an internal implementation
detail. :-)
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: "svn log --limit" argument bug
Posted by David James <dj...@collab.net>.
On 5/17/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> > "svn log --limit 0" and "svn log --limit -5" both seem to do something,
> > although I haven't seen any output from them.
> > I believe both of these should return a syntax error, similar to:
> >
> > c:\temp> svn log -r -1
> > svn: Syntax error in revision argument '-1'
>
> Makes sense to me. Got a patch?
svn log --limit 0 displays all revisions. This makes sense, as "0"
means that there is no limit at all.
svn log --limit -1 (for any negative number) should report a syntax error.
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: "svn log --limit" argument bug
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 5/17/06, John Nicol <ni...@gmail.com> wrote:
>
> Hi there,
>
> "svn log --limit 0" and "svn log --limit -5" both seem to do something,
> although I haven't seen any output from them.
> I believe both of these should return a syntax error, similar to:
>
> c:\temp> svn log -r -1
> svn: Syntax error in revision argument '-1'
Makes sense to me. Got a patch?
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org