You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/20 19:11:25 UTC

[GitHub] [arrow] westonpace commented on pull request #10098: ARROW-11990: [C++][Compute] Handle errors consistently

westonpace commented on pull request #10098:
URL: https://github.com/apache/arrow/pull/10098#issuecomment-823533019


   @nealrichardson In the realm of wild guesses I would investigate before taking much stock in, a change like this...
   
   https://github.com/apache/arrow/pull/10098/files#diff-3eafd7246f6a8c699f10d46e3276852fe44b6853b5517ef10396e561730c09f4L88
   
   ...changes from setting a variable on a class (that variable could then potentially be read in a lot of different places) to an out parameter (which can only be seen by the caller).  By reducing the visible scope of the variable you are writing too you increase the chance the compiler decides that no one else needs to see the change and it can keep it in a register instead of writing it out to RAM somewhere.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org