[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34715: [SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #34715:
URL: https://github.com/apache/spark/pull/34715#discussion_r762497696



##########
File path: dev/run-tests-jenkins.py
##########
@@ -170,10 +170,10 @@ def main():
     if "test-maven" in ghprb_pull_title:
         os.environ["AMPLAB_JENKINS_BUILD_TOOL"] = "maven"
     # Switch the Hadoop profile based on the PR title:
-    if "test-hadoop2.7" in ghprb_pull_title:
-        os.environ["AMPLAB_JENKINS_BUILD_PROFILE"] = "hadoop2.7"
-    if "test-hadoop3.2" in ghprb_pull_title:
-        os.environ["AMPLAB_JENKINS_BUILD_PROFILE"] = "hadoop3.2"
+    if "test-hadoop2" in ghprb_pull_title:
+        os.environ["AMPLAB_JENKINS_BUILD_PROFILE"] = "hadoop2"

Review comment:
       >  do we need to update the infra code for jenkins CI somewhere?
   
   Seems not need.  Jenkins just pass this to build command by
   ```
   if os.environ.get("AMPLAB_JENKINS"):
           # if we're on the Amplab Jenkins build servers setup variables
           # to reflect the environment settings
           build_tool = os.environ.get("AMPLAB_JENKINS_BUILD_TOOL", "sbt")
           scala_version = os.environ.get("AMPLAB_JENKINS_BUILD_SCALA_PROFILE")
           hadoop_version = os.environ.get("AMPLAB_JENKINS_BUILD_PROFILE", "hadoop3")
           test_env = "amplab_jenkins"
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org