You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/02/21 22:04:49 UTC

[jira] [Commented] (FLUME-984) SinkRunner should catch unhanded exceptions and log them like PollingSourceRunner

    [ https://issues.apache.org/jira/browse/FLUME-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212950#comment-13212950 ] 

jiraposter@reviews.apache.org commented on FLUME-984:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3980/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

Catches, logs, and sleeps when a general exception occurs. This is similar to PollingSourceRunner.


This addresses bug FLUME-984.
    https://issues.apache.org/jira/browse/FLUME-984


Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java 9e46d87 

Diff: https://reviews.apache.org/r/3980/diff


Testing
-------

All unit tests pass.


Thanks,

Brock


                
> SinkRunner should catch unhanded exceptions and log them like PollingSourceRunner
> ---------------------------------------------------------------------------------
>
>                 Key: FLUME-984
>                 URL: https://issues.apache.org/jira/browse/FLUME-984
>             Project: Flume
>          Issue Type: Improvement
>          Components: Sinks+Sources
>    Affects Versions: v1.0.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>
> If a Sink throws any exception but EventDeliveryException the sink will die. We should catch the exception, perhaps backoff a bit, and retry like PollingSourceRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira