You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "RostislavPorohnya (via GitHub)" <gi...@apache.org> on 2024/08/01 09:57:20 UTC
[I] Fix disableHostLookup flag logic [cassandra-gocql-driver]
RostislavPorohnya opened a new issue, #1789:
URL: https://github.com/apache/cassandra-gocql-driver/issues/1789
According to the Contributor comment on #1665 issue:
It seems the behavior was like this since commit 83932d6de9af9257339038f8a3a017941c34921d that introduced the option. It seems reasonable to me to treat this as a bug since the documentation says that the driver won't try to discover the hosts. Although `DisableHostLookup` would indeed be better name for a config option like that. And it is not clear to me how users use the DisableInitialHostLookup option, resp. if disabling the lookup always can break someone's program.
Currently, gocql queries `system.peers` in these cases:
* During `Session.init` if `DisableInitialHostLookup` is `false`.
* When reconnecting control connection.
* When calling `Session.AwaitSchemaAgreement` explicitly.
* When a [schema change query successfully executes](https://github.com/gocql/gocql/blob/6132f789ad22c1d19a66c58ac789402d5f1f9be5/conn.go#L1438).
* When a [keyspace change event is received](https://github.com/gocql/gocql/blob/6132f789ad22c1d19a66c58ac789402d5f1f9be5/events.go#L128).
* When a node is added or removed from the cluster. (`Session.addNewNewNode`, `Session.handleNewNode`, `Session.handleRemovedNode`)
We would need to disable it in all these cases, not just during reconnection.
_Originally posted by @martin-sucha in https://github.com/apache/cassandra-gocql-driver/issues/1665#issuecomment-1319988023_
The flag should disable host lookup procedures in cases mentioned above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [I] Fix disableHostLookup flag logic [cassandra-gocql-driver]
Posted by "OleksiienkoMykyta (via GitHub)" <gi...@apache.org>.
OleksiienkoMykyta commented on issue #1789:
URL: https://github.com/apache/cassandra-gocql-driver/issues/1789#issuecomment-2731981378
The issue is well described, but It looks a little bit stuck. Are there any blockers for it, or should it be added to v2.x?
As I understand from the review, we should keep backward compatibility to provide safe migration to the new version of the driver, so after some fixes, it can be merged into the current version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org