You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by br...@apache.org on 2006/04/28 10:43:57 UTC
svn commit: r397805 - in
/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release:
./ config/ phase/ scm/ versions/
Author: brett
Date: Fri Apr 28 01:43:55 2006
New Revision: 397805
URL: http://svn.apache.org/viewcvs?rev=397805&view=rev
Log:
[MRELEASE-98] markup TODO items
Modified:
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/DefaultReleaseManager.java
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/config/PropertiesReleaseConfigurationStore.java
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/config/ReleaseConfiguration.java
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/CheckPomPhase.java
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/GenerateReleasePomsPhase.java
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/MapVersionsPhase.java
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RewritePomsForDevelopmentPhase.java
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RewritePomsForReleasePhase.java
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RunPreparationGoalsPhase.java
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RunTestsPhase.java
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/ScmCheckModificationsPhase.java
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/ScmCommitPhase.java
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/ScmTagPhase.java
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/scm/DefaultScmRepositoryConfigurator.java
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/versions/DefaultVersionInfo.java
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/versions/VersionInfo.java
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/DefaultReleaseManager.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/DefaultReleaseManager.java?rev=397805&r1=397804&r2=397805&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/DefaultReleaseManager.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/DefaultReleaseManager.java Fri Apr 28 01:43:55 2006
@@ -121,14 +121,14 @@
public void perform()
{
- //To change body of implemented methods use File | Settings | File Templates. TODO
+ //To change body of implemented methods use File | Settings | File Templates. TODO [!]
clean();
}
public void clean()
{
- //To change body of implemented methods use File | Settings | File Templates. TODO
+ //To change body of implemented methods use File | Settings | File Templates. TODO [!]
}
void setConfigStore( ReleaseConfigurationStore configStore )
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/config/PropertiesReleaseConfigurationStore.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/config/PropertiesReleaseConfigurationStore.java?rev=397805&r1=397804&r2=397805&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/config/PropertiesReleaseConfigurationStore.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/config/PropertiesReleaseConfigurationStore.java Fri Apr 28 01:43:55 2006
@@ -47,7 +47,7 @@
public PropertiesReleaseConfigurationStore()
{
- // TODO: set properties file somehow
+ // TODO [!]: set properties file somehow
propertiesFile = new File( "release.properties" );
}
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/config/ReleaseConfiguration.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/config/ReleaseConfiguration.java?rev=397805&r1=397804&r2=397805&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/config/ReleaseConfiguration.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/config/ReleaseConfiguration.java Fri Apr 28 01:43:55 2006
@@ -305,10 +305,11 @@
* a default from the merge configuration, but not overridden if it exists.
*
* @param mergeConfiguration the configuration to merge into this configuration
- * @todo double check if these are the expected behaviours
*/
public void merge( ReleaseConfiguration mergeConfiguration )
{
+ // TODO [!]: double check if these are the expected behaviours
+
// Overridden if configured from the caller
this.url = mergeOverride( this.url, mergeConfiguration.url );
this.releaseLabel = mergeOverride( this.releaseLabel, mergeConfiguration.releaseLabel );
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/CheckPomPhase.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/CheckPomPhase.java?rev=397805&r1=397804&r2=397805&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/CheckPomPhase.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/CheckPomPhase.java Fri Apr 28 01:43:55 2006
@@ -36,8 +36,8 @@
public void execute( ReleaseConfiguration releaseConfiguration )
throws ReleaseExecutionException
{
- // TODO: SCM URL is coming from the store but it probably needs to be read from every project instead
- // TODO: prepare release mojo needs to set this correct to either connection or developerConnection as appropriate - new version doesn't handle it
+ // TODO [!]: SCM URL is coming from the store but it probably needs to be read from every project instead
+ // TODO [!]: prepare release mojo needs to set this correct to either connection or developerConnection as appropriate - new version doesn't handle it
if ( StringUtils.isEmpty( releaseConfiguration.getUrl() ) )
{
throw new ReleaseExecutionException(
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/GenerateReleasePomsPhase.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/GenerateReleasePomsPhase.java?rev=397805&r1=397804&r2=397805&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/GenerateReleasePomsPhase.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/GenerateReleasePomsPhase.java Fri Apr 28 01:43:55 2006
@@ -40,7 +40,7 @@
private void generateReleasePoms()
{
-/* TODO
+/* TODO [!]: implement
String canonicalBasedir;
try
@@ -368,7 +368,7 @@
public void simulate( ReleaseConfiguration releaseConfiguration )
{
- // TODO: implement
+ // TODO [!]: implement
}
}
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/MapVersionsPhase.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/MapVersionsPhase.java?rev=397805&r1=397804&r2=397805&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/MapVersionsPhase.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/MapVersionsPhase.java Fri Apr 28 01:43:55 2006
@@ -65,7 +65,7 @@
VersionInfo version = null;
try
{
- // TODO: make sure to test inherited version
+ // TODO [!]: make sure to test inherited version
version = new DefaultVersionInfo( project.getVersion() );
}
catch ( VersionParseException e )
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RewritePomsForDevelopmentPhase.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RewritePomsForDevelopmentPhase.java?rev=397805&r1=397804&r2=397805&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RewritePomsForDevelopmentPhase.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RewritePomsForDevelopmentPhase.java Fri Apr 28 01:43:55 2006
@@ -19,23 +19,22 @@
import org.apache.maven.plugins.release.config.ReleaseConfiguration;
/**
- * TODO: Description.
+ * TODO [!]: Description.
*
* @author <a href="mailto:brett@apache.org">Brett Porter</a>
*/
public class RewritePomsForDevelopmentPhase
implements ReleasePhase
{
- // TODO: include dependencies, dependency management (only rewrite when it was already there, use dom4j)
// TODO: separate release POM removal?
public void execute( ReleaseConfiguration releaseConfiguration )
{
- // TODO
+ // TODO [!]: implement
}
public void simulate( ReleaseConfiguration releaseConfiguration )
{
- // TODO
+ // TODO [!]: implement
}
}
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RewritePomsForReleasePhase.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RewritePomsForReleasePhase.java?rev=397805&r1=397804&r2=397805&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RewritePomsForReleasePhase.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RewritePomsForReleasePhase.java Fri Apr 28 01:43:55 2006
@@ -467,7 +467,7 @@
try
{
// TODO: better handling of encoding. Currently the definition is not written out and is embedded in the intro if it already existed
- // TODO: the XMLOutputter and Writer need to have their encodings aligned
+ // TODO: the XMLOutputter and Writer need to have their encodings aligned.
writer = new FileWriter( pomFile );
if ( intro != null )
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RunPreparationGoalsPhase.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RunPreparationGoalsPhase.java?rev=397805&r1=397804&r2=397805&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RunPreparationGoalsPhase.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RunPreparationGoalsPhase.java Fri Apr 28 01:43:55 2006
@@ -19,7 +19,7 @@
import org.apache.maven.plugins.release.config.ReleaseConfiguration;
/**
- * TODO: Description.
+ * TODO [!]: Description.
*
* @author <a href="mailto:brett@apache.org">Brett Porter</a>
*/
@@ -28,13 +28,13 @@
{
public void execute( ReleaseConfiguration releaseConfiguration )
{
- // TODO: implement
+ // TODO [!]: implement
}
public void simulate( ReleaseConfiguration releaseConfiguration )
{
- // TODO: implement
+ // TODO [!]: implement
}
}
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RunTestsPhase.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RunTestsPhase.java?rev=397805&r1=397804&r2=397805&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RunTestsPhase.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/RunTestsPhase.java Fri Apr 28 01:43:55 2006
@@ -19,7 +19,7 @@
import org.apache.maven.plugins.release.config.ReleaseConfiguration;
/**
- * TODO: Description.
+ * TODO [!]: Description.
*
* @author <a href="mailto:brett@apache.org">Brett Porter</a>
*/
@@ -28,13 +28,13 @@
{
public void execute( ReleaseConfiguration releaseConfiguration )
{
- // TODO: implement
+ // TODO [!]: implement
}
public void simulate( ReleaseConfiguration releaseConfiguration )
{
- // TODO: implement
+ // TODO [!]: implement
}
}
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/ScmCheckModificationsPhase.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/ScmCheckModificationsPhase.java?rev=397805&r1=397804&r2=397805&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/ScmCheckModificationsPhase.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/ScmCheckModificationsPhase.java Fri Apr 28 01:43:55 2006
@@ -99,7 +99,7 @@
List changedFiles = result.getChangedFiles();
- // TODO: would be nice for SCM status command to do this for me
+ // TODO: would be nice for SCM status command to do this for me.
for ( Iterator i = changedFiles.iterator(); i.hasNext(); )
{
ScmFile f = (ScmFile) i.next();
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/ScmCommitPhase.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/ScmCommitPhase.java?rev=397805&r1=397804&r2=397805&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/ScmCommitPhase.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/ScmCommitPhase.java Fri Apr 28 01:43:55 2006
@@ -19,7 +19,7 @@
import org.apache.maven.plugins.release.config.ReleaseConfiguration;
/**
- * TODO: Description.
+ * TODO [!]: Description.
*
* @author <a href="mailto:brett@apache.org">Brett Porter</a>
*/
@@ -28,13 +28,13 @@
{
public void execute( ReleaseConfiguration releaseConfiguration )
{
- // TODO: implement
+ // TODO [!]: implement
}
public void simulate( ReleaseConfiguration releaseConfiguration )
{
- // TODO: implement
+ // TODO [!]: implement
}
}
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/ScmTagPhase.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/ScmTagPhase.java?rev=397805&r1=397804&r2=397805&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/ScmTagPhase.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/phase/ScmTagPhase.java Fri Apr 28 01:43:55 2006
@@ -19,7 +19,7 @@
import org.apache.maven.plugins.release.config.ReleaseConfiguration;
/**
- * TODO: Description.
+ * TODO [!]: Description.
*
* @author <a href="mailto:brett@apache.org">Brett Porter</a>
*/
@@ -28,13 +28,13 @@
{
public void execute( ReleaseConfiguration releaseConfiguration )
{
- // TODO: implement
+ // TODO [!]: implement
}
public void simulate( ReleaseConfiguration releaseConfiguration )
{
- // TODO: implement
+ // TODO [!]: implement
}
}
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/scm/DefaultScmRepositoryConfigurator.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/scm/DefaultScmRepositoryConfigurator.java?rev=397805&r1=397804&r2=397805&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/scm/DefaultScmRepositoryConfigurator.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/scm/DefaultScmRepositoryConfigurator.java Fri Apr 28 01:43:55 2006
@@ -73,7 +73,7 @@
Settings settings = releaseConfiguration.getSettings();
if ( settings != null )
{
- // TODO: this is a bit dodgy - id != host, but since we don't have a <host> field we make an assumption
+ // TODO: this is a bit dodgy - id is not host, but since we don't have a <host> field we make an assumption
Server server = settings.getServer( host );
if ( server != null )
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/versions/DefaultVersionInfo.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/versions/DefaultVersionInfo.java?rev=397805&r1=397804&r2=397805&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/versions/DefaultVersionInfo.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/versions/DefaultVersionInfo.java Fri Apr 28 01:43:55 2006
@@ -49,7 +49,7 @@
* <p/>
* Leading zeros are significant when performing comparisons.
* <p/>
- * TODO: remove component - it isn't relevant
+ * TODO: remove component field - it isn't relevant
* TODO: this parser is better than DefaultArtifactVersion - replace it with this (but align naming) and then remove this from here.
*/
public class DefaultVersionInfo
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/versions/VersionInfo.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/versions/VersionInfo.java?rev=397805&r1=397804&r2=397805&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/versions/VersionInfo.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/versions/VersionInfo.java Fri Apr 28 01:43:55 2006
@@ -45,7 +45,7 @@
VersionInfo getNextVersion();
/**
- * Returns whether this represents a snapshot version. ("xxx-SNAPSHOT");
+ * Returns whether this represents a snapshot version.
*
* @return
*/