You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2015/10/26 17:40:21 UTC
[GitHub] metamodel pull request: METAMODEL-204: Fixed
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/66
METAMODEL-204: Fixed
My attempt at fixing METAMODEL-204 which unfortunately seemed to block the release of MetaModel 4.4.1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel METAMODEL-204
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/66.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #66
----
commit d540f9f5a8f2c164a87c5e5e015b266fd623b2b6
Author: Kasper Sørensen <i....@gmail.com>
Date: 2015-10-26T16:39:35Z
METAMODEL-204: Fixed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-204: Fixed
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/66#discussion_r43093927
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/AbstractQueryRewriter.java ---
@@ -280,6 +280,12 @@ protected String rewriteSelectClause(Query query, SelectClause selectClause) {
}
protected String rewriteSelectItem(Query query, SelectItem item) {
+ if (item.isFunctionApproximationAllowed()) {
+ // function approximation is not included in any standard SQL
+ // constructions - will have to be overridden by subclasses if there
+ // are specialized dialects for it.
+ item = item.replaceFunctionApproximationAllowed(false);
+ }
--- End diff --
Nope, it's removing it, so that it doesn't end up in end at i.e. JDBC contexts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-204: Fixed
Posted by ClaudiaPHI <gi...@git.apache.org>.
Github user ClaudiaPHI commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/66#discussion_r43093767
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/AbstractQueryRewriter.java ---
@@ -280,6 +280,12 @@ protected String rewriteSelectClause(Query query, SelectClause selectClause) {
}
protected String rewriteSelectItem(Query query, SelectItem item) {
+ if (item.isFunctionApproximationAllowed()) {
+ // function approximation is not included in any standard SQL
+ // constructions - will have to be overridden by subclasses if there
+ // are specialized dialects for it.
+ item = item.replaceFunctionApproximationAllowed(false);
+ }
--- End diff --
shouldn't be "true" ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-204: Fixed
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-204: Fixed
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/66#issuecomment-151412033
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---