You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/08/05 14:52:00 UTC

[jira] [Commented] (QPID-8557) [Broker-J] Batching mode for CoalescingCommitter

    [ https://issues.apache.org/jira/browse/QPID-8557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394084#comment-17394084 ] 

ASF GitHub Bot commented on QPID-8557:
--------------------------------------

dakirily opened a new pull request #105:
URL: https://github.com/apache/qpid-broker-j/pull/105


   The purpose of this PR is addition of batching mode to the CoalescingCommitter allowing BDB log flush in configurable chunks and increasing performance (see [QPID-8557](https://issues.apache.org/jira/browse/QPID-8557)).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [Broker-J] Batching mode for CoalescingCommitter
> ------------------------------------------------
>
>                 Key: QPID-8557
>                 URL: https://issues.apache.org/jira/browse/QPID-8557
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>    Affects Versions: qpid-java-broker-8.0.5
>            Reporter: Daniil Kirilyuk
>            Priority: Minor
>
> Although QPID-8547 introduced configurable parameters for CoalescingCommitter, BDB log is flushed to disc on every message. That is caused by calling future.get() inside of org.apache.qpid.server.txn.AsyncCommand.complete(). Such call forces broker to wait until CoalescingCommiter calls #CommitThread#processJobs() making the operation effectively sync instead of async (every message triggers processJobs() and data flush).
> To improve overall performance we suggest to add batching mode for CoalescingCommitter, which would consider BDBVirtualHost parameters and flush data in chunks of size ${qpid.broker.bdbCommiterNotifyThreshold} or every ${qpid.broker.bdbCommiterWaitTimeout} ms (whatever comes first).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org