You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2017/06/02 00:59:50 UTC
[Impala-ASF-CR] IMPALA-4892: Session ID included in error message
Steve Carlin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7051
Change subject: IMPALA-4892: Session ID included in error message
......................................................................
IMPALA-4892: Session ID included in error message
Included the Session ID in the invalid session ID message.
Change-Id: I921c9d13c1bbfb924416dc281649a74add904b66
---
M be/src/service/impala-server.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/7051/1
--
To view, visit http://gerrit.cloudera.org:8080/7051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I921c9d13c1bbfb924416dc281649a74add904b66
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Steve Carlin <st...@arcadiadata.com>
[Impala-ASF-CR] IMPALA-4892: Session ID included in error message
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has abandoned this change.
Change subject: IMPALA-4892: Session ID included in error message
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/7051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I921c9d13c1bbfb924416dc281649a74add904b66
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Steve Carlin <st...@arcadiadata.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-4892: Session ID included in error message
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4892: Session ID included in error message
......................................................................
Patch Set 1:
(1 comment)
Thanks for the patch! Just one minor comment.
http://gerrit.cloudera.org:8080/#/c/7051/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:
PS1, Line 1085: stringstream ss;
: ss << "Invalid session id " << PrintId(session_id);
: return Status(ss.str());
Prefer Substitute - less verbose and a bit easier to read (rest of the code base has been slowly moving that way over the past couple of years).
return Substitute("Invalid session id: $0", PrintId(session_id));
--
To view, visit http://gerrit.cloudera.org:8080/7051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I921c9d13c1bbfb924416dc281649a74add904b66
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Steve Carlin <st...@arcadiadata.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes