You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/07/28 18:19:51 UTC
[GitHub] [phoenix] stoty commented on pull request #1277: PHOENIX-5422 Use Java8 DateTime APIs instead of joda-time APIs
stoty commented on pull request #1277:
URL: https://github.com/apache/phoenix/pull/1277#issuecomment-888521471
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 5m 21s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 16m 59s | master passed |
| +0 | hbaserecompile | 28m 35s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 38s | master passed |
| +1 :green_heart: | checkstyle | 1m 10s | master passed |
| +1 :green_heart: | javadoc | 1m 12s | master passed |
| +0 :ok: | spotbugs | 3m 6s | phoenix-core in master has 964 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 56s | phoenix-pherf in master has 54 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 13s | root in the patch failed. |
| +0 | hbaserecompile | 8m 31s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 38s | the patch passed |
| +1 :green_heart: | javac | 1m 38s | the patch passed |
| -1 :x: | checkstyle | 0m 48s | phoenix-core: The patch generated 96 new + 487 unchanged - 57 fixed = 583 total (was 544) |
| -1 :x: | checkstyle | 0m 23s | phoenix-pherf: The patch generated 16 new + 265 unchanged - 15 fixed = 281 total (was 280) |
| -1 :x: | whitespace | 0m 0s | The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | javadoc | 1m 11s | the patch passed |
| -1 :x: | spotbugs | 3m 19s | phoenix-core generated 6 new + 964 unchanged - 0 fixed = 970 total (was 964) |
||| _ Other Tests _ |
| -1 :x: | unit | 114m 46s | phoenix-core in the patch failed. |
| +1 :green_heart: | unit | 8m 56s | phoenix-pherf in the patch passed. |
| -1 :x: | asflicense | 1m 23s | The patch generated 1 ASF License warnings. |
| | | 182m 58s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.expression.function.RoundJavaDateExpression.correction should be package protected In RoundJavaDateExpression.java: In RoundJavaDateExpression.java |
| | org.apache.phoenix.expression.function.RoundJavaDateExpression.week should be package protected In RoundJavaDateExpression.java: In RoundJavaDateExpression.java |
| | Write to static field org.apache.phoenix.expression.function.RoundJavaDateExpression.correction from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression() At RoundJavaDateExpression.java:from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression() At RoundJavaDateExpression.java:[line 46] |
| | Write to static field org.apache.phoenix.expression.function.RoundJavaDateExpression.week from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression() At RoundJavaDateExpression.java:from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression() At RoundJavaDateExpression.java:[line 43] |
| | Write to static field org.apache.phoenix.expression.function.RoundJavaDateExpression.correction from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression(List) At RoundJavaDateExpression.java:from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression(List) At RoundJavaDateExpression.java:[line 46] |
| | Write to static field org.apache.phoenix.expression.function.RoundJavaDateExpression.week from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression(List) At RoundJavaDateExpression.java:from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression(List) At RoundJavaDateExpression.java:[line 43] |
| Failed junit tests | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1277 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux cd5271c79f17 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 9b76bd5 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/artifact/yetus-general-check/output/whitespace-eol.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 14994 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-pherf U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org