You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/02/26 01:00:55 UTC
[Impala-ASF-CR] IMPALA-13785: Skip rewriting expr of Hive auto-generated label
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22546
Change subject: IMPALA-13785: Skip rewriting expr of Hive auto-generated label
......................................................................
IMPALA-13785: Skip rewriting expr of Hive auto-generated label
IMPALA-10836 introduced the SimplifyCastExprRule optimization to
simplify CAST expressions. However, applying this rewrite rule over
expression referred by Hive auto-generated label has caused
AnalysisException like following:
AnalysisException: Could not resolve column/field reference:
'failing_view._c0'
It is most likely that, before IMPALA-10836, expression referred by Hive
auto-generated label never effectively being rewritten. Thus, the
ExprSubstitutionMap across multiple InlineViewRef was intact.
This patch attempt to fix the issue by making any expression in
SelectList that mapped to Hive auto-generated label ineligible for any
kind of expression rewrite.
Testing:
- Add test case in views-compatibility.test.
- Break test_view_compatibility_hive into 3 separate tests.
- Refactor test_views_compatibility.py to run both EXPLAIN and SELECT
query over the test view.
- Pass test_views_compatibility.py in exhaustive exploration.
- Pass core tests.
Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
---
M fe/src/main/java/org/apache/impala/analysis/SelectList.java
M fe/src/main/java/org/apache/impala/analysis/SelectListItem.java
M testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test
M tests/metadata/test_views_compatibility.py
4 files changed, 108 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/22546/1
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22546/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22546/2//COMMIT_MSG@6
PS2, Line 6:
: IMPALA-13786
> Jira number is wrong. IMPALA-13786 is the right one.
Done
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 15:39:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22546/4/testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test
File testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test:
http://gerrit.cloudera.org:8080/#/c/22546/4/testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test@288
PS4, Line 288: IMPALA=SUCCESS
> Did you check that this failed before your fix? Looks like it uses `explain
Yes, it failed. This match the reproduction test case as described in https://issues.apache.org/jira/browse/IMPALA-13786
http://gerrit.cloudera.org:8080/#/c/22546/4/tests/metadata/test_views_compatibility.py
File tests/metadata/test_views_compatibility.py:
http://gerrit.cloudera.org:8080/#/c/22546/4/tests/metadata/test_views_compatibility.py@134
PS4, Line 134:
> Still has a flake8 warning.
Done
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:22:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13785: Skip rewriting expr of Hive auto-generated label
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13785: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22546/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22546/2//COMMIT_MSG@6
PS2, Line 6:
: IMPALA-13785
Jira number is wrong. IMPALA-13786 is the right one.
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 15:37:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
IMPALA-13786: Skip rewriting expr of Hive auto-generated label
IMPALA-10836 introduced the SimplifyCastExprRule optimization to
simplify CAST expressions. However, applying this rewrite rule over
expression referred by Hive auto-generated label has caused
AnalysisException like following:
AnalysisException: Could not resolve column/field reference:
'failing_view._c0'
It is most likely that, before IMPALA-10836, expression referred by Hive
auto-generated label never effectively being rewritten. Thus, the
ExprSubstitutionMap across multiple InlineViewRef was intact.
This patch attempt to fix the issue by making any expression in
SelectList that mapped to Hive auto-generated label ineligible for any
kind of expression rewrite.
Also addressed some flake8 errors in test_views_compatibility.py.
Testing:
- Add test case in views-compatibility.test.
- Break test_view_compatibility_hive into 3 separate tests.
- Refactor test_views_compatibility.py to run both EXPLAIN and SELECT
query over the test view.
- Pass test_views_compatibility.py in exhaustive exploration.
- Pass core tests.
Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Reviewed-on: http://gerrit.cloudera.org:8080/22546
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/SelectList.java
M fe/src/main/java/org/apache/impala/analysis/SelectListItem.java
M testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test
M tests/metadata/test_views_compatibility.py
4 files changed, 111 insertions(+), 77 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18391/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 19:35:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22546/3/tests/metadata/test_views_compatibility.py
File tests/metadata/test_views_compatibility.py:
http://gerrit.cloudera.org:8080/#/c/22546/3/tests/metadata/test_views_compatibility.py@173
PS3, Line 173:
> The extra line addresses flake8 error:
Ack
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 18:58:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13785: Skip rewriting expr of Hive auto-generated label
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Yida Wu, Peter Rozsa, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22546
to look at the new patch set (#2).
Change subject: IMPALA-13785: Skip rewriting expr of Hive auto-generated label
......................................................................
IMPALA-13785: Skip rewriting expr of Hive auto-generated label
IMPALA-10836 introduced the SimplifyCastExprRule optimization to
simplify CAST expressions. However, applying this rewrite rule over
expression referred by Hive auto-generated label has caused
AnalysisException like following:
AnalysisException: Could not resolve column/field reference:
'failing_view._c0'
It is most likely that, before IMPALA-10836, expression referred by Hive
auto-generated label never effectively being rewritten. Thus, the
ExprSubstitutionMap across multiple InlineViewRef was intact.
This patch attempt to fix the issue by making any expression in
SelectList that mapped to Hive auto-generated label ineligible for any
kind of expression rewrite.
Testing:
- Add test case in views-compatibility.test.
- Break test_view_compatibility_hive into 3 separate tests.
- Refactor test_views_compatibility.py to run both EXPLAIN and SELECT
query over the test view.
- Pass test_views_compatibility.py in exhaustive exploration.
- Pass core tests.
Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
---
M fe/src/main/java/org/apache/impala/analysis/SelectList.java
M fe/src/main/java/org/apache/impala/analysis/SelectListItem.java
M testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test
M tests/metadata/test_views_compatibility.py
4 files changed, 108 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/22546/2
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22546/3/tests/metadata/test_views_compatibility.py
File tests/metadata/test_views_compatibility.py:
http://gerrit.cloudera.org:8080/#/c/22546/3/tests/metadata/test_views_compatibility.py@139
PS3, Line 139: select_query
Can we double check here "if explain_query == select_query"? Then if yes, we throw some error in case we didn't replace the explain plan to a select query as we wanted
http://gerrit.cloudera.org:8080/#/c/22546/3/tests/metadata/test_views_compatibility.py@173
PS3, Line 173:
nit. no need extra line
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 17:54:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Yida Wu, Peter Rozsa, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22546
to look at the new patch set (#4).
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
IMPALA-13786: Skip rewriting expr of Hive auto-generated label
IMPALA-10836 introduced the SimplifyCastExprRule optimization to
simplify CAST expressions. However, applying this rewrite rule over
expression referred by Hive auto-generated label has caused
AnalysisException like following:
AnalysisException: Could not resolve column/field reference:
'failing_view._c0'
It is most likely that, before IMPALA-10836, expression referred by Hive
auto-generated label never effectively being rewritten. Thus, the
ExprSubstitutionMap across multiple InlineViewRef was intact.
This patch attempt to fix the issue by making any expression in
SelectList that mapped to Hive auto-generated label ineligible for any
kind of expression rewrite.
Also addressed some flake8 errors in test_views_compatibility.py.
Testing:
- Add test case in views-compatibility.test.
- Break test_view_compatibility_hive into 3 separate tests.
- Refactor test_views_compatibility.py to run both EXPLAIN and SELECT
query over the test view.
- Pass test_views_compatibility.py in exhaustive exploration.
- Pass core tests.
Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
---
M fe/src/main/java/org/apache/impala/analysis/SelectList.java
M fe/src/main/java/org/apache/impala/analysis/SelectListItem.java
M testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test
M tests/metadata/test_views_compatibility.py
4 files changed, 110 insertions(+), 77 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/22546/4
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13785: Skip rewriting expr of Hive auto-generated label
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13785: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18379/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 01:30:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:25:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Yida Wu, Peter Rozsa, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22546
to look at the new patch set (#3).
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
IMPALA-13786: Skip rewriting expr of Hive auto-generated label
IMPALA-10836 introduced the SimplifyCastExprRule optimization to
simplify CAST expressions. However, applying this rewrite rule over
expression referred by Hive auto-generated label has caused
AnalysisException like following:
AnalysisException: Could not resolve column/field reference:
'failing_view._c0'
It is most likely that, before IMPALA-10836, expression referred by Hive
auto-generated label never effectively being rewritten. Thus, the
ExprSubstitutionMap across multiple InlineViewRef was intact.
This patch attempt to fix the issue by making any expression in
SelectList that mapped to Hive auto-generated label ineligible for any
kind of expression rewrite.
Testing:
- Add test case in views-compatibility.test.
- Break test_view_compatibility_hive into 3 separate tests.
- Refactor test_views_compatibility.py to run both EXPLAIN and SELECT
query over the test view.
- Pass test_views_compatibility.py in exhaustive exploration.
- Pass core tests.
Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
---
M fe/src/main/java/org/apache/impala/analysis/SelectList.java
M fe/src/main/java/org/apache/impala/analysis/SelectListItem.java
M testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test
M tests/metadata/test_views_compatibility.py
4 files changed, 108 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/22546/3
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22546/3/tests/metadata/test_views_compatibility.py
File tests/metadata/test_views_compatibility.py:
http://gerrit.cloudera.org:8080/#/c/22546/3/tests/metadata/test_views_compatibility.py@125
PS3, Line 125: # explain and run a simple query on the view created by creator_engine in
: # reader_engine
: exp_res = test_case.get_query_exp_res(creator_engine)
> Running the test manually, I'm still seeing redundant Invalidate query. I'l
Done
http://gerrit.cloudera.org:8080/#/c/22546/3/tests/metadata/test_views_compatibility.py@139
PS3, Line 139: select_query
> Ack
Done
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 19:12:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13785: Skip rewriting expr of Hive auto-generated label
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13785: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18378/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 01:28:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11521/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 23:39:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/22546/3/tests/metadata/test_views_compatibility.py
File tests/metadata/test_views_compatibility.py:
http://gerrit.cloudera.org:8080/#/c/22546/3/tests/metadata/test_views_compatibility.py@125
PS3, Line 125: if creator_engine == HIVE:
: invalidate_query = "invalidate metadata {0}".format(test_case.hive_view_name)
: engine_to_exec[IMPALA](invalidate_query, create_query, None)
Running the test manually, I'm still seeing redundant Invalidate query. I'll tidy this up in next patch set.
http://gerrit.cloudera.org:8080/#/c/22546/3/tests/metadata/test_views_compatibility.py@139
PS3, Line 139: select_query
> Can we double check here "if explain_query == select_query"? Then if yes, w
Ack
http://gerrit.cloudera.org:8080/#/c/22546/3/tests/metadata/test_views_compatibility.py@173
PS3, Line 173:
> nit. no need extra line
The extra line addresses flake8 error:
E302 expected 2 blank lines, found 1
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 18:56:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18398/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:49:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 23:39:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 05:07:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 4:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/22546/4/tests/metadata/test_views_compatibility.py
File tests/metadata/test_views_compatibility.py:
http://gerrit.cloudera.org:8080/#/c/22546/4/tests/metadata/test_views_compatibility.py@134
PS4, Line 134: )
flake8: E501 line too long (91 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 19:12:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Yida Wu, Peter Rozsa, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22546
to look at the new patch set (#5).
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
IMPALA-13786: Skip rewriting expr of Hive auto-generated label
IMPALA-10836 introduced the SimplifyCastExprRule optimization to
simplify CAST expressions. However, applying this rewrite rule over
expression referred by Hive auto-generated label has caused
AnalysisException like following:
AnalysisException: Could not resolve column/field reference:
'failing_view._c0'
It is most likely that, before IMPALA-10836, expression referred by Hive
auto-generated label never effectively being rewritten. Thus, the
ExprSubstitutionMap across multiple InlineViewRef was intact.
This patch attempt to fix the issue by making any expression in
SelectList that mapped to Hive auto-generated label ineligible for any
kind of expression rewrite.
Also addressed some flake8 errors in test_views_compatibility.py.
Testing:
- Add test case in views-compatibility.test.
- Break test_view_compatibility_hive into 3 separate tests.
- Refactor test_views_compatibility.py to run both EXPLAIN and SELECT
query over the test view.
- Pass test_views_compatibility.py in exhaustive exploration.
- Pass core tests.
Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
---
M fe/src/main/java/org/apache/impala/analysis/SelectList.java
M fe/src/main/java/org/apache/impala/analysis/SelectListItem.java
M testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test
M tests/metadata/test_views_compatibility.py
4 files changed, 111 insertions(+), 77 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/22546/5
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22546/4/testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test
File testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test:
http://gerrit.cloudera.org:8080/#/c/22546/4/testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test@288
PS4, Line 288: IMPALA=SUCCESS
Did you check that this failed before your fix? Looks like it uses `explain select`, which seems like it should be sufficient.
http://gerrit.cloudera.org:8080/#/c/22546/4/tests/metadata/test_views_compatibility.py
File tests/metadata/test_views_compatibility.py:
http://gerrit.cloudera.org:8080/#/c/22546/4/tests/metadata/test_views_compatibility.py@134
PS4, Line 134: )
> flake8: E501 line too long (91 > 90 characters)
Still has a flake8 warning.
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:16:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13786: Skip rewriting expr of Hive auto-generated label
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 5: Code-Review+2
Thanks Riza for the fix.
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 23:31:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13785: Skip rewriting expr of Hive auto-generated label
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13785: Skip rewriting expr of Hive auto-generated label
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198
Gerrit-Change-Number: 22546
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 09:05:47 +0000
Gerrit-HasComments: No