You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "gianm (via GitHub)" <gi...@apache.org> on 2023/10/26 06:00:47 UTC
[PR] FireHydrant: Return empty from getSegmentForQuery when adapter is null. (druid)
gianm opened a new pull request, #15260:
URL: https://github.com/apache/druid/pull/15260
This can happen if the segment is removed while a query is in progress. Returning empty causes the server to use ReportTimelineMissingSegmentQueryRunner, which causes the Broker to look for the segment somewhere else.
Fixes #12168.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix NPE caused by realtime segment closing race, fix possible missing-segment retry bug. (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm commented on PR #15260:
URL: https://github.com/apache/druid/pull/15260#issuecomment-1782274097
CI failures appear to be coverage-related. I'll need to add some more tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix NPE caused by realtime segment closing race, fix possible missing-segment retry bug. (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm merged PR #15260:
URL: https://github.com/apache/druid/pull/15260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix NPE caused by realtime segment closing race, fix possible missing-segment retry bug. (druid)
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 commented on code in PR #15260:
URL: https://github.com/apache/druid/pull/15260#discussion_r1394109630
##########
server/src/main/java/org/apache/druid/segment/realtime/plumber/Sink.java:
##########
@@ -452,4 +483,53 @@ public short getAtomicUpdateGroupSize()
{
return shardSpec.getAtomicUpdateGroupSize();
}
+
+ /**
+ * Helper for {@link #acquireSegmentReferences(Function, boolean)}. Separate method to simplify testing (we test this
+ * method instead of testing {@link #acquireSegmentReferences(Function, boolean)} directly).
+ */
+ @VisibleForTesting
+ static List<SinkSegmentReference> acquireSegmentReferences(
Review Comment:
should be annotated @Nullable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org