You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/07/14 11:43:15 UTC
[GitHub] [nifi] exceptionfactory opened a new pull request #5215: NIFI-8782 Added Rate-Limiting for Access Token Requests
exceptionfactory opened a new pull request #5215:
URL: https://github.com/apache/nifi/pull/5215
#### Description of PR
NIFI-8782 Adds a new NiFi configuration property named `nifi.web.max.access.token.requests.per.second` to support rate-limiting for HTTP Access Token requests to `/nifi-api/access/token`. Leveraging the Jetty `DoSFilter`, the configuration property supports rejecting requests with HTTP 429 responses when the number of requests exceeds the configured maximum per second.
The property uses a default value of 25 requests per second, following the default value from `DoSFilter`, which should be sufficient for a reasonable number of interactive authentication attempts. This instance of the `DoSFilter` also leverages the existing configuration property that supports excluding selected remote addresses from rate-limiting.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #5215: NIFI-8782 Added Rate-Limiting for Access Token Requests
Posted by GitBox <gi...@apache.org>.
thenatog commented on pull request #5215:
URL: https://github.com/apache/nifi/pull/5215#issuecomment-879955721
Reviewing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #5215: NIFI-8782 Added Rate-Limiting for Access Token Requests
Posted by GitBox <gi...@apache.org>.
thenatog commented on pull request #5215:
URL: https://github.com/apache/nifi/pull/5215#issuecomment-880108460
+1 Tested this and got a HTTP 429 when sending too many requests in 1 second. Checked that other contexts were not affected by the changes, and the code changes look good to me, will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog closed pull request #5215: NIFI-8782 Added Rate-Limiting for Access Token Requests
Posted by GitBox <gi...@apache.org>.
thenatog closed pull request #5215:
URL: https://github.com/apache/nifi/pull/5215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org