[GitHub] [lucene-solr] mayya-sharipova edited a comment on pull request #2186: LUCENE-9334 Consistency of field data structures

[GitBox <gi...@apache.org>]

mayya-sharipova edited a comment on pull request #2186:
URL: https://github.com/apache/lucene-solr/pull/2186#issuecomment-783604414


   @jpountz  Adrien, I also wanted to ask your opinion about the behaviour of `writer.updateDocValues(Term term, fieldX)`, as I am not sure what to do in this case:
   1.  What should happen if `fieldX` doesn't exist in the segment (but exists globally)? 
   2. What should happen if `fieldX` doesn't have docValues enabled?
   
   Before in both of these cases `updateDocValues` worked well creating a new `FieldInfo` in the current segment if it doesn't exist or enabling doc values.
   
   But with current PR as the field schema is fixed, we can:
   1. Thrown an  error? Or allow only in a case where the global `fieldX`  is only a docValues field?
   2. Throw an error, as field schema is fixed now and  docValues can't be enabled.
   
   WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org