You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2019/10/29 16:29:18 UTC

[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #350: Upgrade to quarkus 0.27.0

ppalaga commented on a change in pull request #350: Upgrade to quarkus 0.27.0
URL: https://github.com/apache/camel-quarkus/pull/350#discussion_r340185059
 
 

 ##########
 File path: extensions/aws-eks/deployment/src/main/java/org/apache/camel/quarkus/component/aws/eks/deployment/AwsEKSProcessor.java
 ##########
 @@ -57,19 +57,21 @@ ExtensionSslNativeSupportBuildItem activateSslNativeSupport() {
     }
 
     @BuildStep
-    SubstrateProxyDefinitionBuildItem httpProxies() {
-        return new SubstrateProxyDefinitionBuildItem("org.apache.http.conn.HttpClientConnectionManager",
-                "org.apache.http.pool.ConnPoolControl", "com.amazonaws.http.conn.Wrapped");
+    NativeImageProxyDefinitionBuildItem httpProxies() {
+        return new NativeImageProxyDefinitionBuildItem(
+            "org.apache.http.conn.HttpClientConnectionManager",
 
 Review comment:
   Mixing reformatting with other changes makes it harder to review and you do this regularly. Could you please consider putting the formatting changes into a separate commit next time? 
   
   For the record, the style in https://github.com/apache/camel/blob/master/etc/eclipse/CamelCodeFormatter.xml is different from what you do but I like your style better than the official CamelCodeFormatter.xml
   cc https://github.com/apache/camel-quarkus/issues/337 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services