You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/12/07 00:27:35 UTC

[GitHub] spark pull request #23226: [SPARK-26286][TEST] Add MAXIMUM_PAGE_SIZE_BYTES e...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23226#discussion_r239662927
  
    --- Diff: core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java ---
    @@ -622,6 +622,17 @@ public void initialCapacityBoundsChecking() {
         } catch (IllegalArgumentException e) {
           // expected exception
         }
    +
    +    try {
    +      new BytesToBytesMap(
    +        taskMemoryManager,
    +        1,
    +        TaskMemoryManager.MAXIMUM_PAGE_SIZE_BYTES+1);
    --- End diff --
    
    `E_BYTES+1` -> `E_BYTES + 1`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org