You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/06/12 10:34:28 UTC

[GitHub] [tinkerpop] spmallette commented on issue #1130: typo fix

spmallette commented on issue #1130: typo fix
URL: https://github.com/apache/tinkerpop/pull/1130#issuecomment-501216212
 
 
   your first pull request looks fine. thanks for taking the time to offer spelling/grammar fixes. the only thing you might want to consider for future PRs of this type is the version. we currently maintain 3.3.x on the `tp33` branch, 3.4.x on the `tp34` branch and 3.5.0 (unreleased) on `master`, so given that you've submitted this PR against `master` the change will technically only go to 3.5.0 which has no release date as of yet. It would be nice if you could target future PRs to the earliest branch to show the problem, then when it's merged it will apply to all the branches ahead of it when we merge the change forward. For this PR I will cherry-pick your change to `tp33` as the problem does exist there:
   
   http://tinkerpop.apache.org/docs/3.3.7/reference/#vertexprogram
   
   and then merge it forward to the other branches. Hope that makes sense...feel free to ask questions if you need clarification.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services