[GitHub] [madlib] orhankislal commented on a change in pull request #433: Kmeans: Add automatic optimal cluster estimation

[GitBox <gi...@apache.org>]

orhankislal commented on a change in pull request #433: Kmeans: Add automatic optimal cluster estimation
URL: https://github.com/apache/madlib/pull/433#discussion_r321485089
 
 

 ##########
 File path: src/ports/postgres/modules/kmeans/test/kmeans.sql_in
 ##########
 @@ -91,6 +91,59 @@ SELECT * FROM kmeans('kmeans_2d', 'array[x,y]', 'centroids', 'array[x,y]');
 SELECT * FROM kmeanspp('kmeans_2d', 'array[x,y]', 10);
 SELECT * FROM kmeans_random('kmeans_2d', 'arRAy [ x,y]', 10);
 
+-- Test kmeanspp_auto
 
 Review comment:
   We did have some assertions for output tables but the randomized nature of the initial seeding makes the outcomes very unpredictable. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services