[GitHub] qpid-proton-j pull request #18: NO-JIRA Minor code improvements (e.g. semico...

[gemmellr <gi...@git.apache.org>]

Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/qpid-proton-j/pull/18#discussion_r231104760
  
    --- Diff: proton-j/src/main/java/org/apache/qpid/proton/message/impl/MessageImpl.java ---
    @@ -49,11 +49,7 @@
           }
         }
     
    -    private static final ThreadLocal<EncoderDecoderPair> tlsCodec = new ThreadLocal<EncoderDecoderPair>() {
    -          @Override protected EncoderDecoderPair initialValue() {
    -            return new EncoderDecoderPair();
    -          }
    -      };
    +    private static final ThreadLocal<EncoderDecoderPair> tlsCodec = ThreadLocal.withInitial(EncoderDecoderPair::new);
    --- End diff --
    
    I spend about half of yesterday chasing down some sporadic test failures I was seeing in the python test suite, that seemed like it must be from local changes I had in that area. Instead, it eventually turned out to be this change, as I also had this commit in my tree to rebase it. For whatever reason, altering this seems to cause a behaviour shift that the Jython based tests don't like (at least in my env), leading to sporadic failure to run any of the tests. I'll be committing an updated version without this change.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org