You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/10/01 03:53:25 UTC

[GitHub] [submarine] huang06 opened a new pull request, #1000: tests: replace legacy tmpdir with tmp_path

huang06 opened a new pull request, #1000:
URL: https://github.com/apache/submarine/pull/1000

   ### What is this PR for?
   <!-- A few sentences describing the overall goals of the pull request's commits.
   First time? Check out the contributing guide - https://submarine.apache.org/contribution/contributions.html
   -->
   
   Pytest provides both `tmp_path` and `tmpdir` fixtures to indicate the temporary directory.
   
   Nowadays, it's preferred to use the `tmp_path` fixture which returns a `pathlib.Path` instead of the legacy `tmpdir` which returns `py.path.local`.
   
   ### What type of PR is it?
   
   Improvement
   
   ### Todos
   
   ### What is the Jira issue?
   <!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
   * Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. `SUBMARINE-23. PR title`
   -->
   
   <https://issues.apache.org/jira/browse/SUBMARINE-1333>
   
   ### How should this be tested?
   <!--
   * First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
   * Strongly recommended: add automated unit tests for any new or changed behavior
   * Outline any manual steps to test the PR here.
   -->
   
   This PR modified the following conftest files:
   
   ```text
   submarine-sdk/pysubmarine/tests/ml/pytorch/model/conftest.py
   submarine-sdk/pysubmarine/tests/ml/tensorflow/model/conftest.py
   submarine-sdk/pysubmarine/tests/ml/tensorflow_v2/model/conftest.py
   ```
   
   Then, run pytest on ` tests/ml/` to validate the changes:
   
   ```bash
   cd submarine-sdk/pysubmarine
   python3 -m venv .venv
   source .venv/bin/activate
   pip install -U pip setuptools wheel
   pip install -r github-actions/test-requirements.txt
   pip install -e '.[tf2,pytorch]'
   
   pytest tests/ml/
   ```
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [submarine] codecov[bot] commented on pull request #1000: SUBMARINE-1333. Replace legacy tmpdir with tmp_path

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1000:
URL: https://github.com/apache/submarine/pull/1000#issuecomment-1264235361

   # [Codecov](https://codecov.io/gh/apache/submarine/pull/1000?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1000](https://codecov.io/gh/apache/submarine/pull/1000?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8afc76e) into [master](https://codecov.io/gh/apache/submarine/commit/ca25b9de97e730fd0ff4441eee198cda3e779e4d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca25b9d) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1000   +/-   ##
   =========================================
     Coverage     15.13%   15.13%           
     Complexity     1078     1078           
   =========================================
     Files           246      246           
     Lines         24140    24140           
     Branches       3481     3481           
   =========================================
     Hits           3654     3654           
     Misses        20272    20272           
     Partials        214      214           
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org