You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/08 11:29:50 UTC

[GitHub] twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins

twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r208500644
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
 ##########
 @@ -155,6 +158,90 @@ class Table(
     select(withResolvedAggFunctionCall: _*)
   }
 
+  /**
+    * Creates table version function backed up by this table as a history table.
+    *
+    * @param version field for the [[TableVersionFunction]]. Must points to a time indicator
 
 Review comment:
   Why do we call it version if it must be a time attribute anyway? Btw time indicator is internal name. Use `time attribute`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services